GHOP #159: views integration for the workflow-ng logging module

fago - January 18, 2008 - 19:12
Project:Workflow-ng
Version:5.x-2.x-dev
Component:Module Integration
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:GHOP
Description

To complete the new workflow-ng logging module created by the GHOP task http://code.google.com/p/google-highly-open-participation-drupal/issues/... add the missing views integration to it.
Provide "views fields" for each database column and views filter for 'type' and 'category'. Also add a sort criteria for the time.
As Views 5.x-1.x doesn't support listing users directly, make use of the usernode module (http://drupal.org/project/usernode) and provide the user views integration for the usernode. You can take the buddylist views integration as guidance (http://drupal.org/project/buddylist). Furthermore http://drupal.org/handbook/modules/views/api documents the views API.

#1

fago - January 18, 2008 - 19:15
Title:GHOP: views integration for the workflow-ng logging module» GHOP #159: views integration for the workflow-ng logging module

http://code.google.com/p/google-highly-open-participation-drupal/issues/...

#2

corsix - January 18, 2008 - 20:08
Status:active» needs review

Attached first draft.

AttachmentSize
workflow_ng_log.module_views.patch 9.72 KB

#3

fago - January 19, 2008 - 11:55
Status:needs review» needs work

* You need to check, whether the usernode module is active. If not, the table "usernode" might not exist, which might produce errors. So only add the user views integration if usernode is active.

* The default views list all nodes / users, even if there are no log entries. I think you need to do a inner join.

* Naming: Workflow-ng doesn't use the term "node" in the UI. Use "content" instead.

#4

corsix - January 19, 2008 - 12:16
Status:needs work» needs review

* Added a module_exists check for usernode
* Changed table joins from left to inner
* Changed the name/menu path/description of the node-log view to Content log

AttachmentSize
workflow_ng_log.module_views2.patch 9.86 KB

#5

fago - January 19, 2008 - 14:43
Status:needs review» fixed

that's it - good work as usual :)
-> committed to 5.x-2.x, thanks.

#6

Anonymous (not verified) - February 2, 2008 - 14:51
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.