Contributed source code [#211803]

Previous e-mail conversation between mcarbone and develCuy

Hi Fernando,

Can you explain point 1 to me? karma hides comments that are below
the minimum karma threshold by hooking into db_rewrite_sql.
Unfortunately, Drupal 5 and earlier do not use db_rewrite_sql when
displaying a node's comments. How did you get around this in an
elegant way?

Perhaps you should post this as an issue on the project page, so that
others can benefit from this discussion.

If 2 is only styling, I probably will not add that, as anyone can do
it by overriding the theme. Neil Drumm's intention with karma was to
simulate the module as it worked on Scoop. I don't intend to do more
with this module.

Can you explain the fivestar integration in further detail?

Thanks,
marco

On Jan 18, 2008 5:07 PM, Fernando P. García
- Hide quoted text -
wrote:
> Hi Marco,
>
> 1. About bug fixing:
> I've researched on theme and hooks to control comments sorting without core
> hacks, I don't agree to hack core :)
> 2. About the handup and handdown style
> - Is just another style of rating, but binary: 0 or 1 and that is.
>
> My questions
> 1. are you open to include point 1 in D5? if yes, I'll be pleased to
> collaborate doing that for you, I will follow your instructions carefully.
> 2. Since is only styling and D5 is current version, why not include this??,
> again, I'll provide any resource available to make this job for you.
> 3. For fivestar integration, do you agree to let me create a separate
> module: karma_extensions? Then we can merge projects after D6...
>
> Thanks for your answer.
>
> Blessings!
>
>
>
> On Jan 18, 2008 7:30 PM, Marco Carbone wrote:
> > Hi develCuy,
> >
> > So, coincidentally, you sent this message as I'm working on upgrading
> > karma to Drupal 6. I have no intention to add new features to karma
> > on Drupal 5 or earlier, since the module is not fully functional for
> > those versions (unless you hack Drupal core).
> >
> > I would be happy to consider your changes for Drupal 6, however. Can
> > you please submit issues on the karma project page of the
> > functionality you would like to see added? When I release the dev
> > version of Karma for D6, you can also submit patches for your changes
> > as well, if you'd like.
> >
> > Let me know if you have any questions,
> > -marco
> >
> > On Jan 18, 2008 4:06 PM, wrote:
> > >
> > > Hello,
> > >
> > > I've modified karma for a customer and want to share changes.
> > > Take a look at http://develcuy.elblog.de/review user mario
> > >
> > > Main changes
> > > - New rating stouyle: hand up/ hand down
> > > - Fixed sorting algorithm of comments in node-page
> > > - Pager added pager
> > > - Integration with fivestar for custom view: "View all reviews"
> > >
> > > It would be nice to me if you approve to integrate 100% of my changes,
> but
> > > I'm able to publish a separate module with functionalities you don't
> agree,
> > > something like: karma_extensions.
> > >
> > > Blessings!
> > >
> >

Comment	File	Size	Author
#4	karma-hand_updown-5.x-0.2.tar_.gz	22.51 KB	develcuy
#4	comment.tpl_.php_.tar_.gz	508 bytes	develcuy
#2	comment.tpl_.php_.gz	391 bytes	develcuy
#2	karma-hand_updown-5.x-0.1.tar_.gz	22.46 KB	develcuy

Comments

Comment #1

develcuy commented 19 January 2008 at 03:24

Title:

feature extensions and bug fixing

» Explaining points

Point 1

a. created new function:

function karma_comment_enabled_check($comment){
  static $_cache = array();
  $_node_id = $comment->nid;
  
  // Prevents infinite loop
  $comment->karma_checked = true;
  
  // Node's cache
  if(!isset($_cache[$_node_id]))
    $_cache[$_node_id] =& node_load($_node_id);
  
  $_node =& $_cache[$_node_id];
  
  if(variable_get('karma_comment_enabled_'.$_node->type, false)){
    if(!isset($_node->comments_printed)){
      print karma_comment_render($_node);
      $_node->comments_printed = true;
    }
    return true;
  }else
    return false;
}

b. Prevents infinite loop:

function karma_comment(&$comment, $op) {
  global $user;
  // Prevents infinite loop
  if($comment->op == 'Preview comment' || arg(1) == 'edit' || arg(1) == 'reply'){
    if(is_object($comment))
      $comment->karma_checked = true;
    else
      $comment['karma_checked'] = true;
  }
  ....

c. Then installed karma_comment_enabled_check() in comment.tpl.php:

<?php if ($comment->karma_checked || !karma_comment_enabled_check($comment)) {?>

TEMPLATE CODE

<?php } ?>

How does it works?
karma_comment_enabled_check() breaks comment_render() execution and then it calls karma_comment_render(), last one is now on charge of displaying comments thread.

Point 2

hand up and down is digg like, and I've added php, jquery and css, it is a new rating interface, and karma makes sense with hand up and down. Ok, sorry to say: "just styling" but is a new rating interface option.

Sure Drumm wanted to just clone the original one, but Drupal Karma have to be extended in my opinion, take linux as example, it originally wanted to be just unix, but is doing a lot more.

Fivestar integration

In order to display a congruent comments list in node_page and node's comments page(displays only thread of comments), I've made new fivestar "view all reviews" feature to display comments sorted first by karma criteria and then by configured comments sorting. Demo at: http://develcuy.elblog.de/review/fivestar/view_all/1 compare to http://develcuy.elblog.de/review/node/1

Comment #2

develcuy commented 24 January 2008 at 23:34

Title:

Explaining points

» Contributed source code

Status	File	Size
new	karma-hand_updown-5.x-0.1.tar_.gz	22.46 KB
new	comment.tpl_.php_.gz	391 bytes

It seems to be easier for you to browse my changes in source code.
Attached modified karma module and comment.tpl.php example

Comment #3

mcarbone commented 30 January 2008 at 20:40

Hmm, my inclination is to think that if it is of interest to have the karma module provide a way for comments below thresholds to be hidden via templating, then it can be done more elegantly than what you have provided. But even so, it's a good idea and I hope others can follow a similar example if they want to get karma working somewhat for D4 or D5 without hacking core.

But I'm not sure it is worth adding such functionality to the module. For one, it wouldn't work on all db_rewrite_sql references to comments, so any blocks, table or list views, etc. that display comments would still be broken. Second, I've been working on updating karma for D6, which is right around the corner, and where this is no longer an issue.

My intention is to concentrate on getting karma for D6 exclusively, as I doubt that many people will adopt this module this late in the D5 cycle. As for new features, such as different icons or integration with other contrib modules, I won't consider those until I've finished getting karma working reliably on D6.

Comment #4

develcuy commented 23 February 2008 at 08:14

Status	File	Size
new	comment.tpl_.php_.tar_.gz	508 bytes
new	karma-hand_updown-5.x-0.2.tar_.gz	22.51 KB

This is a new version of karma hand_updown with some bugs fixing.
Blessings!

Comment #5

Steven Brown commented 30 April 2011 at 03:25

Status:

Active

» Closed (won't fix)

The Karma module has since changed maintainers and headed in a new direction. So I am closing this issue.

Contributed source code

Comments

Comment #1

Point 1

Point 2

Fivestar integration

Comment #2

Comment #3

Comment #4

Comment #5

News items

Our community

Documentation

Drupal code base

Governance of community