URL aliases are ignored

This was a relatively easy fix (assuming I'm not missing something obvious). I've seen others request this functionality; here's my change, in case it helps someone else:

271c271,278
< return !($secure xor preg_match($regexp, $path)) ? 1 : 0;
---
>
> $result = preg_match($regexp, $path);
> if (function_exists('drupal_get_path_alias')) {
> $path_alias = drupal_get_path_alias($_GET['q']);
> $result |= preg_match($regexp, $path_alias);
> }
>
> return ($secure xor $result) ? 0 : 1;

Here's a patch file (against the latest 5.x-1.x-dev) with some changes:

1. drupal_get_path_alias should test the passed value of $path instead of $_GET['q'] because the securepages_match function is used for more than just the current browser URL
2. I've change the logic on the return statement back to defaulting to 0 as it was before. I don't think that change pertains to this issue and so should be submitted as a separate issue if you feel that it needs to be modified.

See also: "Securepages does not work with Clean URLs enabled"
http://drupal.org/node/206864

pheinrich,

Do you plan to incorporate this logic into a future revision of Secure Pages?

This patch works beautifully for me, a lot pages on my site weren't being secured until I installed this patch

many thanks

The patch also worked for me. I applied the patch to securepages-6.x-1.7-beta2 and it fixed my alias problems. Many thanks!

patch at #2 also works for me on drupal 6. Can we get this committed in both version please?

Bump, this patch is still not committed to 5 head.

I too have had need to apply this patch to 6.x-1.7 (release, not beta) to make Secure Pages work like I expect.

Please apply this patch to the latest versions. It worked perfectly and allows the functionality that should be there. Thanks a bunch!

Thanks I have committed this to dev

Thanks for committing this to the 6.x branch. Can we get it committed to 5.x as well?

The patch was actually written against the 5.x branch. I just tested and it still applies cleanly with some line offset.