In the update from 1.56 to 1.57 the function _userpoints_transaction was changed from "return TRUE always if the function exits at the bottom" to "return the $params['status']". In fact, the $params['status'] is used to hold moderation status inside of this function so we return the moderation setting - not very useful. If a site has moderation disabled (that is set to accept all) then userpoints_userpointsapi thinks that this function has failed even though it finished just fine.

CommentFileSizeAuthor
#1 return_true_at_bottom_211886.patch609 bytesgreggles

Comments

greggles’s picture

Status: Active » Needs review
StatusFileSize
new609 bytes

Attached patch goes back to returning TRUE always.

kbahey’s picture

Version: 5.x-3.2 » 5.x-3.x-dev
Status: Needs review » Fixed

Committed to 3.x and HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.