Closed (won't fix)
Project:
CiviCRM Count Block
Version:
master
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Jan 2008 at 05:20 UTC
Updated:
23 Apr 2013 at 18:13 UTC
This is a hook_uninstall patch that should get rid of any traces of civicrm_countblock should it be uninstalled.
List of Destruction:
| Comment | File | Size | Author |
|---|---|---|---|
| civicrm_countblock_uninstall.patch | 651 bytes | kourge |
Comments
Comment #1
dmitrig01 commentedLooks good to me! (reviewed)
Comment #2
douggreen commentedWhile this works fine, it performs a SQL query (see variable_del) for every single variable and delta, many of which aren't set.
You might look at how corsix is doing this for views_filterblock #211943. While his implementation isn't quite finished, I think it's a better way of doing this. (The helper function isn't necessary, and I'm not suggesting that you use a helper function, I'm suggesting that you look at looping through the existing variables to figure out what to delete.)
Comment #3
douggreen commented