One of our workshop students last time brought this up (and looks like didn't file a bug about it against our requests, tsk tsk :P).

It's unintuitive that the opposite of drupalGet is drupalPost*Request*. So let's shorten it up so that a) we have less typing ;) and b) the pair of functions is more intuitive.

CommentFileSizeAuthor
#2 simpletest-drupalpost-212282-2.patch65.04 KBwebchick

Comments

Rok Žlender’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev

I'm all for this improvement. It will require a lot of search and replace.

webchick’s picture

Status: Active » Needs review
StatusFileSize
new65.04 KB

Here's a patch, lightly tested. Thanks, Eclipse! ;)

Rok Žlender’s picture

That is one big patch. It looks good to me but when I commit this where can we publish this API change or can we just assume people follow issue queue :)

webchick’s picture

Right. Good question.

We shouldn't assume that people follow the issue queue. I definitely wouldn't commit this patch to 5.x.

However, there is yet to be an official 6.x release, afaik. So I think now is an opportune time to commit something like this (and any other API clean-ups/fixes) /before/ there's a stable official release. Then we can include notification in the release notes for 6.x-1.0, at the very least.

Very high on my "when I get discretionary time" list is finishing both in-code SimpleTest API documentation, as well as a thorough cleaning (if not a complete rewrite) of http://drupal.org/simpletest. However, said discretionary time is going to be hard to come by for the next couple weeks. :( But those are also perfect places to advertise API changes.

Rok Žlender’s picture

Status: Needs review » Fixed

Committed thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.