better interop with taxonomy_menu in cat_aliases

I just tried this patch and the action failed in all but one place. I am patching against the most current pathauto module.

Here is the output from running patch:

Hunk #1 FAILED at 292.
Hunk #2 FAILED at 378.
Hunk #3 FAILED at 416.
Hunk #4 FAILED at 434.
Hunk #5 succeeded at 494 with fuzz 2 (offset -63 lines).
Hunk #6 FAILED at 620.
5 out of 6 hunks FAILED -- saving rejects to file ./pathauto.module.rej

Pathauto has been completely rewritten since aws created that patch. It's more modular now, so it should be possible to implement this without patching pathauto, by creating a pathauto_taxonomy_menu.inc file using the API I've provided. And I'm hoping aws (or someone else) will do that - I'm looking forward to getting some feedback on the API.

i just got back to work on this site.. so i'm trying now to use your API to create auto aliases for all taxonomy_menu paths.. but i'm not having much luck. i started with your pathauto_node.inc file, but after changing all the function names to the new module (taxonomy_menu) they don't seem be running.

an api spec would be really helpful, as would any other docs and advice. it looks like it's pretty clean and straight forward, but i must be missing something.

If there's anything unclear or incomplete about the API documentation in README.txt (under "Implementing automatic aliases for a module"), please let me know. Where specifically are you having trouble?

Thanks.

I'm closing for this now - if there's some specific feedback on where the current API documentation in README.txt falls short, please reopen this with your comments.

Under the current design center of pathauto (as a service module for other modules), I will only support core modules in the "official" distribution, support for contributed modules is in the hands of the module authors and interested consumers of those modules.

I just wanted to point out to the more php aware working on the projects, that there is still interest in getting that "it just works" with taxonomy_menu working again. Perhaps it would be easier to just explain how to setup pathauto to do just that, without writing the code to make it happen. Either way, I apperciative of the help and the great work so many put forward on drupal and these modules.

This is an important issue. Without this fix there are two duplicate and confusing sets of category pages: One through taxonomy menu, the other through pathauto.

Any feedback on how to fix this is appreciated.

Can you describe what the problem you see is? Not everyone uses taxonomy_menu...

As previously mentioned, pathauto provides an API for other contributed modules to hook into its automated alias generation features. Unless something is lacking in the API, this issue probably should belong to taxonomy_menu.

yeah, the problem probably is in taxonomy menu. I've just had this problem on a site I'm setting up, and reading the above comments would agree that it's taxonomy_menu that needs fixing.

I don't understand why taxonomy menu uses different urls to taxonomy, anyway...

Support for integrating taxonomy_menu and pathauto should come from the taxonomy_menu side. If the pathauto API or its documentation is lacking, please let me know.

Reassigning, to not show anymore in 7.x issues.