Thanks for a great module!
Here is a preliminary RTL version. Take a look here (my temporary site), and press on one of the thumbnails on the button of the screen.
Adding the following CSS to my theme does the trick, for Firefox:
#imageData #imageDetails {float: right; text-align: right; font-size: 14px}
#imageData #bottomNavZoom {
float: left;
left:0px;
margin-left:-30px;
}
#imageData #bottomNavClose {
position: relative;
float: left;
left:0px;
}
The 1st image shows how it looks in Firefox. Just great!
However - there are some IE issue - any ideas?
IE7 RTL issues
What really bothers me is how the 'Close' and 'Zoom' buttons behave in Internet Explorer. It seems like an IE bug - the close button go to the left, as in the second image, but when I hover above it, it's position suddenly becomes OK, as seen on the third image. The Zoom button doesn't show at all (I did manage to show it in erratic positions with some tweaks, but I don't remember what I did).
Removing underlines
Another issue which happens in the RTL version is underlines under image links. How to remove the red underline when I hover over the prev/next links? I tried the following (but it didn't help):
#prevLink:hover, #prevLink:visited:hover, #nextLink:visited:hover, #nextLink:hover {
text-decoration:none;
}
Looking at the javascript, I see that some of this is hardcoded into the javascript, to compensate for IE bugs. Should we put the decoration into the javascript too?
Thanks in advance,
Amnon
Note: This CSS should be really saved as a new file, lightbox-rtl.css, in the lightbox CSS directory (this is the new Drupal 6 RTL convention), but first let's track a bug.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | bluemarine-rtl-D6.jpg | 71.23 KB | druvision |
| #11 | pushbutton-rtl.jpg | 67.1 KB | druvision |
| lightbox-rtl-ie7-after-hover-on-close-button.jpg | 28.36 KB | druvision | |
| lightbox-rtl-ie7.jpg | 29.36 KB | druvision | |
| lightbox-rtl-firefox.jpg | 21.48 KB | druvision |
Comments
Comment #1
druvision commentedmis-spelling corrections:
let's track a bug = let's track *the* bug.
on the button of the screen = on the bottom of the screen
Comment #2
stella commentedHi levavie,
Thanks for the patch! I've added a slightly modified version to CVS which should hopefully fix the zoom button positioning issue in IE. Lightbox now automatically detects your drupal language's RTL setting and loads the corresponding css file. I also added RTL support to the lightbox lite layout, and added it to both 5.x and 6.x versions.
Please test it out with the latest dev release, which will be available later today.
Cheers,
Stella
Comment #3
stella commentedReleased in 5.x-2.3 and 6.x-1.3.
Cheers,
Stella
Comment #4
druvision commentedI've tested 2.3 in my site and lightbox doesn't load at all. So I've reverted back to 2.2 and everything works fine.
Comment #5
druvision commentedComment #6
druvision commentedTesting was done in both IE and Firefox
Comment #7
druvision commentedComment #8
stella commentedWhat way does it not work? Does it work for LTR languages? Or is it just for RTL languages that it doesn't work? If the latter, be sure you have the i18n module enabled and your language configured as RTL.
If the problem persists, then I can't help you unless you re-enable lightbox2 5.x-2.3 and send me a link to the site where I can investigate, or failing that the page source.
Cheers,
Stella
Comment #9
druvision commentedGreat!
After setting the automatic image handling definitions and clearing the cache I've now successfully upgraded the site to 5.x-2.3.
Lightbox2 now loads lightbox-rtl.css and there is no longer need for my theme changes (Installing the I18n module is usually needed need for mulilingual sites, however I've installed it since your code depends on the language_rtl function offered by the i18n module. Hopefully this won't be needed in Drupal 6 since RTL lang detection is supposed to be part of core).
IE RTL issues
Still - IE buttons are going in wiered positions - the same issue as before. Here is a new RTL demo done with version 5.x-2.3.
Comment #10
stella commentedNo, there's no need for the i18n module for RTL support in the D6 version.
The IE issue is because of a conflict with the lightbox2 module and your garlandrtl theme. Lightbox2 works as expected with other themes.
Cheers,
Stella
Comment #11
druvision commentedThanks, stella. I feel lightbox RTL is quite usable even in the current situation and you've done a great job.
No, The IE issue happens on all RTL themes. Show me an RTL theme in which it doesn't happen. The same happens with all d6 default themes - even on BlueMarine-RTL or Pushbutton-RTL. IE7 screen captures attached. Register at my D6 test site to check it.
No, the same happens even with Drupal5 with bluemarine and the danger4g/art4_blue which are bluebreeze-based.
I admit, RTL CSS is hard. People collaborated for days to make the core themes RTLized for Drupal6. Let's leave this issue open - I will see if I can get other people to collaborate on the issue.
Amnon
Comment #12
druvision commentedComment #13
stella commentedThis should be fixed now and will be available in a dev release later today.
Cheers,
Stella
Comment #14
stella commentedReleased in Lightbox2 5.x-2.4.
Cheers,
Stella
Comment #15
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.