When editing and saving the digest template, the contents of the digest item body are overwritten with the contents of the digest body.

CommentFileSizeAuthor
#2 subscriptions_content.digest.patch1.51 KBsalvis

Comments

samuelet’s picture

I confirm this.
Moreover, two digest mails without !bodies rendered were sent to me, one after 1 hour and 20 minutes the other. And my cron runs every 20 minutes.

salvis’s picture

Status: Active » Needs review
StatusFileSize
new1.51 KB

Argh, there are at least two bugs in this code...

This patch will help (no cvs commit, because it needs to become more robust).

salvis’s picture

@samuelet: I didn't see your reply before and I don't quite understand what you mean. Please try this patch and if the issue persists, then explain it in more details.

P.S. The best way to recover from the digest template mess is to delete
subscriptions-digest from {mail_edit}, and
subscriptions-digest and subscriptions-digest-separator from {subscriptions_mail_edit}

This will restore the default digest templates.

gustav’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the patch. Works fine.

samuelet’s picture

Yes, patch works.
About my previuos post, !bodies were not rendered (i mean replaced with the real node body) simply because !bodies is a variable only in the mail_edit digest body section (it was in the item body section because of the bug).
About time, i referred to the sent interval for my subscriptions, which is 86400, so it was strange for me to receive two notification mails in 1 hour and 20 minutes (five cron runs on my drupal site).
Could they be generated by different type of subscriptions (i mean one from content type subscription and the other from taxonomy subscription)?

salvis’s picture

Thanks for the clarification.

As for the Send Interval, please see http://drupal.org/node/204874...

salvis’s picture

Version: 5.x-2.0-beta9 » 5.x-2.0-beta10
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.