Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Field "location" in table "locales_source" is too short. The patch makes it limitless.
Comment | File | Size | Author |
---|---|---|---|
#16 | drupal-4_6-HEAD-update137-add.diff | 1.44 KB | baudolino |
#13 | drupal-4_6-update131-add.diff | 1.3 KB | patryk |
#12 | update_135_1.patch.HEAD.diff | 1.54 KB | baudolino |
#10 | drupal-4-6-locales-fix.diff | 1.21 KB | patryk |
#9 | update_135.patch.diff | 1.38 KB | baudolino |
Comments
Comment #1
Dries CreditAttribution: Dries commentedThere is a similar location-row in the watchdog table.
The MySQL database scheme also uses varchar(128) so it is not specific to PostgreSQL.
I wouldn't recommend making it limitless. Maybe 255 is more sensible?
Comment #2
patryk CreditAttribution: patryk commentedHmm... maybe you're right. I came accross a polish language pack which had 177 characters in that field, it could easily have more, but I think 256 will be good for now.
The field in watchdog is not revelant to this bug as it handles the filename of event occured and can contain only one location, unlike many as here.
The new patch attached and bug details changed.
Comment #3
Dries CreditAttribution: Dries commentedCommitted to HEAD and DRUPAL-4-6. Thanks patryk.
Comment #4
jhriggs CreditAttribution: jhriggs commentedThe field was changed to 256 by this patch. Not sure about pgsql, but the max for a CHAR/VARCHAR in mysql is 255. Patch attached.
Note: Shouldn't there also be a update in updates.inc for this since it is a schema change?
Comment #5
jhriggs CreditAttribution: jhriggs commentedI didn't realize the patch had been applied to 4.6 also. Marking as critical.
Comment #6
patryk CreditAttribution: patryk commentedI made a small investigation. Postgres eats 1 GB strings for breakfast unlike MySQL which sucks with it's 255 character limit until 5.0.3 excluding ;) (even 5.0.3 has limit of 65536 chars)
Some references:
http://www.postgresql.org/docs/7.4/interactive/datatype-character.html - as Drupal must use v7.4 at least
http://dev.mysql.com/doc/mysql/en/char.html
In the result let's do that field 255 chars long in both databases to be coherent.
PS: I'm thinking about something to ease pgsql 7.4's column type change. 8.0 has it already implemented. Maybe some hyper-clever function? ;)
The new patch against today's CVS attached. Includes updates in updates.inc.
Comment #7
drumm+1 for the database.mysql part which I sucessfully used. That file in the 4.6 branch is rather broken.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to HEAD. The update.inc-part did not apply against HEAD though. Marking this active.
Comment #9
baudolino CreditAttribution: baudolino commentedThis should patch update.inc
Comment #10
patryk CreditAttribution: patryk commentedbaudolino has provided the patch for HEAD's update.inc, I'm providing the same for DRUPAL-4-6's. Hope it is the last patch for this task :)
Comment #11
Dries CreditAttribution: Dries commentedPatches no longer apply. Sorry. If time permits, please update the patches.
Comment #12
baudolino CreditAttribution: baudolino commentedHere's the patch for HEAD.
Comment #13
patryk CreditAttribution: patryk commentedpatch against DRUPAL-4-6. Commit fast ;)
Comment #14
Dries CreditAttribution: Dries commentedCommitted to DRUPAL-4-6. Thanks for your persistence Patryck. Marking this 'active' until we have an updated patch for HEAD.
Comment #15
baudolino CreditAttribution: baudolino commentedThe patch I submitted for HEAD before patryk sent his for 4.6 is updated and applies! Don't let the 135 in the name fool you, I just inserted it before the last update (which becomes 136), since chronologically that's what happened. Why would it make a difference in HEAD the order in which they're numbered?
Comment #16
baudolino CreditAttribution: baudolino commentedNevermind, didn't notice the silent update. Here we go again. Update 137 for HEAD coming up!
Comment #17
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #18
(not verified) CreditAttribution: commented