Download & Extend
Currency Exchange » Issues

Better display of result

Posted by xushi on January 21, 2008 at 1:43pm
Project:Currency Exchange
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:amateescu
Status:closed (fixed)

Issue Summary

Hi,

I think we need a better way to display the result, than a drupal message. This way, it can be easier to customise, move around, and well, look better :)

Login or register to post comments

Comments

#1

Posted by kbahey on January 21, 2008 at 3:44pm

You have a patch for that?

#2

Posted by xushi on January 22, 2008 at 7:59pm

No i don't.

#3

Posted by 2222a on February 14, 2008 at 3:05pm

I second this request too. It needs to stand out. Sadly I have no clue on how to do it through

#4

Posted by chriscohen on October 15, 2008 at 11:11am

This is not exactly a patch, but rather the whole thing as a zip file. I'm sorry but I have no idea how to turn this into a patch. I'm hoping someone else will be able to do this.

This is a modified copy of 5.x-1.1, with a new sub-module called 'currency_toolbox'. It adds a new, blank form field to the currency form, and when the 'convert' button is clicked, an AJAX function is called and the conversion takes place, putting the converted amount into the empty form field, negating the need to reload the page at all.

There are a couple of issues with this approach, but my development time has run out on the site where this is used, so I presently cannot continue development.

  • The AJAX part resides in a separate module (mainly so that I can use a separate part of the repository). This could probably be put in the main currency module.
  • There is no visual indicator (like a throbber or something) between the user clicking 'convert' and the currency conversion being returned, so the user has no feedback in the case when it takes a long time to convert.
  • There is no check performed as to whether cURL is enabled. This will cause the conversion to fail silently instead of providing the user with feedback (especially important because most default installs of PHP have cURL disabled).
AttachmentSize
currency_ajax.zip 35.65 KB

#5

Posted by amateescu on December 5, 2010 at 11:14pm
Version:master» 6.x-1.x-dev
Status:active» postponed

The 5.x branch is not maintained anymore. Maybe we can fix this in 6.x.

#6

Posted by amateescu on January 11, 2011 at 12:07am
Assigned to:Anonymous» amateescu
Status:postponed» active

Will write a patch for this in a couple of days.

#7

Posted by amateescu on March 7, 2011 at 9:19pm
Status:active» needs review

And here is the patch.

AttachmentSize
212527-better_display_of_result-1.patch 7.02 KB

#8

Posted by amateescu on March 7, 2011 at 9:21pm
Status:needs review» fixed

Commited with 7219c81.

#9

Posted by System Message on March 21, 2011 at 9:31pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

Posted by shyamprakash on August 8, 2011 at 12:14pm

Hello all i have configure currency module (Drupal 6) functionality is fine but we need to Better display of result would you pls help?

#11

Posted by shyamprakash on August 8, 2011 at 12:17pm
AttachmentSize
currecy exchange.jpg 30.56 KB
nobody click here