Proposed patches will fix all of bugs that I found in current 5.x-1.x-dev revision and it seems that with this patch and og_files.install on http://drupal.org/node/208625#comment-699610 og_files is ready for daily use, but more testing is needed :)

Fixed bugs are:
1) og_files_file_download was not behave correctly when setting drupal file system to private. Accessing files from /files dir was not possible
2) error in og_files_file_download sql command
3) og_file_list_form was not able to correctly handle multiple sub folders
4) while creating new directories og_file_list_form_submit sometimes added '//' in new directory path
5) og_files_install is commented enabling use of og_files.install (see http://drupal.org/node/208625)

CommentFileSizeAuthor
#14 og_files.zip9.91 KBpivica
#5 og_files.module.patch3.29 KBpivica
#2 og_files.module.patch7.48 KBpivica
#1 og_files.module.txt8.83 KBpivica

Comments

pivica’s picture

pivica commented
StatusFileSize
new og_files.module.txt8.83 KB

Here is also complete og_files.module with fixed bugs.

pivica’s picture

pivica commented
StatusFileSize
new og_files.module.patch7.48 KB

Sorry I forgot patch file in first post

nath’s picture

nath commented

One small formal comment: You have made a lot of whitespace changes in your patch. This makes finding the real differences difficult.

pivica’s picture

pivica commented

Yes I know, sorry for that. I am using Eclipse and was probably applied auto format in some point on file so editor inserted/erased all that whitespace. Will try not to do that in the future.

pivica’s picture

pivica commented
StatusFileSize
new og_files.module.patch3.29 KB

OK here is a better patch suggestion. Same as #2 but without whitespace changes.

nath’s picture

nath commented
Status: Needs review » Reviewed & tested by the community

You could completely remove the install function instead of just commenting it out. Apart from that, the new patch is much more readable. It looks fine to me.

Anonymous’s picture

Anonymous (not verified) commented

Thanks for this patch, the module now works for me as it's meant to.

Looking forward to an update.

STNyborg’s picture

STNyborg commented

I am newbie to Drupal modules and especially patches - thus not sure if my question is dumb (!)... As I read the thread it looks like the latest patch will solve my database problem with og_files. However I don't know how to add patches as I have just ftp'd modules to the Drupal module directory. Please help.

scarer’s picture

scarer commented

This patch still doesn't make the module appear in the administration listings.

Is there anything else that might be done to make this module work on a Drupal 5.7 site?

Thanks!

Cheers,

Sarah

scarer’s picture

scarer commented

ah by the way for applying patches you just upload the patch file to the directory where the module file is stored then in ssh you issue the following command:

patch < whatever.patch

and it should work if it's written correctly

sarah

scarer’s picture

scarer commented

All the patches just fail...

scarer’s picture

scarer commented

Try creating a table like this:

CREATE TABLE og_files (gid INT NOT NULL, data TEXT NOT NULL)

still testing to see whether this is working or not...

softtouch’s picture

softtouch commented

Some of us do not have a chance to use patch files, is it possible to attach here a complete module with the bug fix included?
The files module is one of the modules we need badly (developer groups), but I also can not use patch files...

pivica’s picture

pivica commented
StatusFileSize
new og_files.zip9.91 KB

For all of you that can't properly patch og_files I have created patched module with all files in zip archive. Please remember to first uninstall previous version of og_files module and also to erase it from system table as described in http://drupal.org/node/208625#comment-697643.

softtouch’s picture

softtouch commented

This is great! Thank you!

the fatman’s picture

the fatman commented

I managed to install the files in pivica's zip archive, many thanks for that, and now the module appears to install correctly but I can't find it.

It doesn't have it's own settings page or menu item, no mention in access control, I can't find any reference to it anywhere, what am I missing here ?

asak’s picture

asak commented

I've just installed the patched module (as provided @ #14) - but get no settings/permissions/anything for the module (same as #16 i guess).

the fatman’s picture

the fatman commented

Found it

When you add a new group, or edit an old one, there's a button way down the bottom: enable files for this group

asak’s picture

asak commented

Thanks.... ;)

wundo’s picture

wundo commented

pivica could you send me a patch with the last version you made?

pivica’s picture

pivica commented

hi wundo,

i didn't develop any new code for this module so archive from #14 is my last version and patch from #5 is last patch i have used.

wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

Fixed ;)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.