Download & Extend
Issues

rss feed wrong date

Posted by pp on January 22, 2008 at 10:41am
Project:Drupal core
Version:6.x-dev
Component:node system
Category:bug report
Priority:normal
Assigned:gdevlugt
Status:closed (fixed)

Issue Summary

When the rss feed is created by the node_feed function(node_modul ~1877), it uses the date funtion.

<?php
date($item->created,'r')
?>

This is a PHP function to format the date. The results depend on server settings, not Drupal settings. I think we should use Drupal's format_date function:

<?php
  format_date($items->created,'custom','r')
?>

(Drupal 6.x also)
Login or register to post comments

Comments

#1

Posted by pp on January 23, 2008 at 1:24pm
Version:5.x-dev» 6.x-dev

#2

Posted by gdevlugt on January 26, 2008 at 10:59pm
Assigned to:Anonymous» gdevlugt
Status:active» needs review

Hi,

This sounds valid enough. If i'm running say a dutch website on a webserver in the US, it makes no sense to have articles with the local date of the webserver. I added a patch for D6 head which will fix this.

AttachmentSizeStatusTest resultOperations
fix_rss_feed_date.patch1.21 KBIgnored: Check issue status.NoneNone

#3

Posted by moshe weitzman on January 27, 2008 at 1:37pm
Status:needs review» reviewed & tested by the community

looks good.

#4

Posted by Gábor Hojtsy on January 27, 2008 at 6:13pm
Status:reviewed & tested by the community» fixed

Thanks, committed.

#5

Posted by Anonymous (not verified) on February 10, 2008 at 6:13pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.