Download & Extend

Node delete confirm page parameter mix up?

Project:Drupal core
Version:6.x-dev
Component:node system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

node.module - line 1609 of the theme('confirm' ...) function is setting the page title with drupal_set_title($question);

However, the node delete function is putting html (from the theme('placeholder', $node->title) call) in to the html page tag. Surely the message "Are you sure you want to delete %title?" should appear on the page, and not really in the window title bar?

Comments

#1

Is this still an issue in 4.6.3 or HEAD?

#2

Version:4.6.0» x.y.z

Yes, there still is a drupal_set_title($question) in confirm_form().

#3

Verified.
Seems easy to fix.

AttachmentSizeStatusTest resultOperations
printscreen.png26.02 KBIgnored: Check issue status.NoneNone

#4

Version:x.y.z» 6.x-dev
Status:active» postponed (maintainer needs more info)

Still an issue?

#5

This is now line 2392 in Drupal 5.12. Change the line to:

t('Are you sure you want to delete %title? This action cannot be undone.', array('%title' => $node->title)),

#6

Status:postponed (maintainer needs more info)» needs review

#7

Status:needs review» postponed (maintainer needs more info)

There is no patch.

#8

Sorry ended up not putting a patch cause this if assigned to 6.x-dev and my fix was for 5.x.

#9

Status:postponed (maintainer needs more info)» closed (won't fix)

Closing this issue because of a lack of activity.

nobody click here