node.module - line 1609 of the theme('confirm' ...) function is setting the page title with drupal_set_title($question);

However, the node delete function is putting html (from the theme('placeholder', $node->title) call) in to the html page tag. Surely the message "Are you sure you want to delete %title?" should appear on the page, and not really in the window title bar?

CommentFileSizeAuthor
#3 printscreen.png26.02 KBmagico

Comments

Uwe Hermann’s picture

Uwe Hermann commented

Is this still an issue in 4.6.3 or HEAD?

killes@www.drop.org’s picture

killes@www.drop.org commented
Version: 4.6.0 » x.y.z

Yes, there still is a drupal_set_title($question) in confirm_form().

magico’s picture

magico commented
StatusFileSize
new printscreen.png26.02 KB

Verified.
Seems easy to fix.

stevenpatz’s picture

stevenpatz
he/him
commented
Version: x.y.z » 6.x-dev
Status: Active » Postponed (maintainer needs more info)

Still an issue?

coderintherye’s picture

coderintherye commented

This is now line 2392 in Drupal 5.12. Change the line to:

t('Are you sure you want to delete %title? This action cannot be undone.', array('%title' => $node->title)),

coderintherye’s picture

coderintherye commented
Status: Postponed (maintainer needs more info) » Needs review
stevenpatz’s picture

stevenpatz
he/him
commented
Status: Needs review » Postponed (maintainer needs more info)

There is no patch.

coderintherye’s picture

coderintherye commented

Sorry ended up not putting a patch cause this if assigned to 6.x-dev and my fix was for 5.x.

dpearcefl’s picture

dpearcefl commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing this issue because of a lack of activity.