_taxonomy_term_select() - $blank needs to be in a valid array element

subscribe

Could you mark this needs review? I know it’s only one line, but wouldn’t all those eager reviewers find a patch useful?

I’m guessing this is by design, as the row added here is not a term, so should be treated differently. It is not over-writing any other term as there are none to over-write, and;

$a = array();
$a[''] = 'blank';

$a[] = 'One';
$a[] = 'Two';
$a[] = 'Three';
print_r($a);
 

gives;-

Array
(
    [] => blank
    [0] => One
    [1] => Two
    [2] => Three
)

I can only guess that views is not expecting a non-integer key, or is not handling it properly.

I don’t think that passing a 0 meaning no label to this function, is ideal – null would be better – and $blank is not an ideal name for this argument: if($blank) {...} doesn’t convey the logic of the code, in fact, the opposite.

Using '' as the key is a little obscure if this array is being used elsewhere: 'default' might be more explicit, but changing this might break other code that relies on ''. ‘Magic’ values are always difficult.

If the maintainers of taxonomy are happy to change the keys, and this fixes the issue – then fine, but I think this is caused by views.

Agreed with above review. Please re-open against either 6.0 or a contributed module if the problem persists.

we're not going to 6.0 any time soon unfortunately, so is the patch our only solution? It seems strange that the key would be changed just for the sake of changing it without an explanation of what the benefits are, do I doubt this is the case. However, changing the key back to $options[] = $blank fixes the issue with Views and doesn't appear to break anything else. Can someone explain why the key was changed to $options[''] = $blank and what I might be missing as having broken since changing it back using the patch?

Many thanks in advance and thanks to Harry for this patch.