Closed (fixed)
Project:
External Links
Version:
5.x-1.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2008 at 02:56 UTC
Updated:
22 Feb 2008 at 22:51 UTC
I just upgraded to 5.x-1.4, but it seems to cause the link icon to show up next to images with external links. I'm using Drupal 5.6 and the default jquery.js file that came with it. When I used 5.x-1.3, the icons (correctly) weren't showing up next to external image links.
Comments
Comment #1
ellanylea commentedI've used:
- Drupal 5.5 with extlink 5.x-1.3
- Drupal 5.6 with extlink 5.x-1.3
- Drupal 5.4 with extlink 5.x-1.4
In all 3 cases, the icon showed up next to images with external links...
I haven't installed a jquery module or anything, just a default Drupal installation with the extlink module (which is awesome, btw!)
Comment #2
quicksketchThanks, seems this is the case. I avoided it for quite some time, but I don't think there's a way for me to find if links contain an image in all versions of jQuery. I broke down and put in an IF statement switching on jQuery versions. 1.4 apparently worked with jQuery 1.1 and higher, but not 1.0.4 (the Drupal 5 default). The new check switches the method depending on the jQuery version. I'd suggest sticking with 1.3 until 1.5 is released shortly. Thanks!
Comment #3
kalin9 commentedI also had this "issue" though it's not exactly an issue, and just to add i had a lot of links, i think primarily on page nodes that 1.4 does not work on. I had to roll back to 1.3 and works great, though I found one link in my footer it's not working for.
dumb question but i'm new to drupal, where does this .js that seems to do everything get called from? I was trying to troubleshoot but was surprised to find what appears to only be admin stuff in the.module file. No worries to answer if you're busy i'll keep digging and figure it out.
thanks for this module it's great.
edit
doh okay think i found docs on where it's called
http://api.drupal.org/api/file/developer/topics/javascript_startup_guide...
i might make some changes, i'll contribute any i do as a patch
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.