Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
color.module
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
23 Jan 2008 at 04:47 UTC
Updated:
25 Feb 2008 at 07:13 UTC
I was sort of surprised to find that color.module automatically presumes you want to use an image with it. Perhaps this module was made with the presumption that it would used only with themes utilizing graphics. I don't think drupal shouldn't punish themes who do not utilize the module's base_image slicer (http://drupal.org/project/cleanstate).
This simple patch will eliminate bugs like this http://drupal.org/node/176537 while expanding color.module to fit themes that only wish to use the css color switching features. :)
Tested in Drupal 5.6, with Garland (w/ image) and cleanstate (w/o image) themes.
Although my first impression is it's safe, I am not very security-oriented, so I am putting this on code needs review.
| Comment | File | Size | Author |
|---|---|---|---|
| color_imageless.patch | 547 bytes | tonyn |
Comments
Comment #1
birdmanx35 commentedFeature requests go to 7.x-dev.
Comment #2
tonyn commentedThis has already been committed to 6.x-dev (http://drupal.org/node/213172).
Comment #3
tonyn commentedThis patch was meant to give the (to be) legacy drupal 5.x compatibility fix. Even if cleanstate is the only imageless theme utilizing color.module at the time, that doesn't say people theming this popular legacy version of drupal won't bump into this caveat in the future. It's not fair for them or Druplicon.
Couldn't this be submitted as a bugfix? It merely suppresses errors, after all. It bites.
Comment #4
tonyn commentedtypo
Comment #5
drummCommitted to 5.x.
In the future, please do not open two issues for the same bug. The single issue can be moved around versions as needed. And watch your indentation, I had to fix a tab which should have been spaces.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.