Code update to fix current issues (the code doesn't work as is)
dragonfyre6 - January 23, 2008 - 06:25
| Project: | Profile Enforcer |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | dragonfyre6 |
| Status: | needs work |
Description
fixes a similar issue to: node/154568
This occurs on lines 238, 234, 230. I think it may be on one other one, but you can run a diff.
This also fixes the issue described at: node/155205 in post 4, and at: node/186396 for the whole issue.
Basically, the uid was hardcoded in the module to 7. If your 7th user was all filled out profile wise, you had no issues.
This also fixes some grammar issues in debug mode.
For anyone that wants this prior to it being included, just download the attached file, and overwrite your existing one in the profile_enforcer module directory.
| Attachment | Size |
|---|---|
| profile_enforcer.module.tar_.gz | 2.95 KB |
#1
Crap. That included a line of my own debugging code, and will screw up your redirects. This is the one I meant to upload.
#2
Confirm patch works, but causes infinite redirect loop when an unauthorised user visits the site.
I've turned off content access for unauthorised users, this probably causes all redirects by profile enforcer to redirect to the main login page, which profile enforcer tries to redirect to profile edit page again, causing the loop.
Confirmed problem goes away when profile enforcer is disabled.
#3
Did a quick patch. Wrapped a uid check before line 114 and after line 164. Also added suitable debug statements and comments. Please review.
#4
Very nice. Much better.
I had no block appearing for unauthorized users, so it wasn't a problem for me. Thanks for catching that.
#5
#186396 is a duplicate of this issue.
#6
#243116 is a duplicate of this issue.
#7
We need a patch.
#8
Status? What version is the above made from (there is mention elsewhere-- http://drupal.org/node/186396-- of a newer version in "bugtracker")? Is this module currently maintained?