The fieldsets in the sidebar of the edit form for group nodes do not expand when JS is aggregated in IE8 on Windows XP. This was tested using the latest code from the code repository and then again with the patch in https://drupal.org/node/2130469 and a fresh install of Commons with only the default modules enabled.

Since the error only occurs when JS is aggregated it is probably a syntax error in a JS file which is only a problem when the files are aggregated.

This error is not present in Commons 3.2 and was introduced in Commons 3.3.

This already reported error may be related: https://drupal.org/node/2091497

I've attached 3 screenshots:
1) edit form with no JS aggregation
2) edit form with JS aggregation
3) the JS error related to https://drupal.org/node/2091497

CommentFileSizeAuthor
#5 commons-2131949-4-placeholder.patch2.05 KBZarabadoo
IE8-WinXP-jserror.png27.48 KBjastraat
IE8-WinXP_js_compressed.png76.48 KBjastraat
IE8-WinXP_no_agg_works.png28.6 KBjastraat

Comments

daniel.c’s picture

daniel.c commented

I'm experiencing the same issue in IE9 and Commons 3.4.

neillawrence’s picture

neillawrence commented

Same problem here - IE9 and Commons 3.4

ezra-g’s picture

ezra-g commented
Component: Code » Theme
Assigned: Unassigned » Zarabadoo
Issue tags: +commons 7.x-3.6 radar
Zarabadoo’s picture

Zarabadoo commented

As a status update for folks having issues with this, the issue seems to be the Placeholder module javascript. Disabling this module will render the pages useable again, but the form elements will not show placeholder text in the older IE browsers. I am working to see if there is a fix that can be done and still maintain placeholder functionality for the browsers.

Zarabadoo’s picture

Zarabadoo commented
StatusFileSize
new commons-2131949-4-placeholder.patch2.05 KB
Zarabadoo’s picture

Zarabadoo commented

It seems that best decision is to replace the Placeholder module with the Elements module. If we keep the former, it would require the addition of jQuery Update and more js complexity. It is hard to justify that additional headache to support legacy browsers. Elements does not worry about supporting older browsers that do not support the placeholder attribute, so it actually reduces the js complexity. The above patch in #5 will allow for this changeover in future builds.

Zarabadoo’s picture

Zarabadoo commented
Status: Active » Needs review
ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Looks good. Committed - Thanks!

http://drupalcode.org/project/commons.git/commit/28159cb

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.