So my lawyers told me they needed photo credits and my editors told me they needed captions and the ability to 'feature' a photo. I don't think this patch should be included, but I wanted to post it just in case it was useful to anyone.

CommentFileSizeAuthor
#14 imagefield-5.x-2.2.patch10.46 KBtomchuk
#6 imagefield_caption.patch10.8 KBmvc
imagefield_caption.patch10.8 KBtomchuk

Comments

dopry’s picture

dopry commented
Status: Active » Closed (fixed)
Fayna’s picture

Fayna commented

This is great, thank you! :)

bcobin’s picture

bcobin commented

I implemented the patch - with errors...

patching file imagefield.install
patching file imagefield.module
Hunk #1 succeeded at 83 with fuzz 1 (offset -57 lines).
Hunk #2 FAILED at 123.
Hunk #3 succeeded at 277 (offset -105 lines).
Hunk #4 FAILED at 304.
Hunk #5 succeeded at 506 with fuzz 1 (offset -160 lines).
Hunk #6 succeeded at 546 (offset -159 lines).
Hunk #7 succeeded at 607 with fuzz 2 (offset -160 lines).
Hunk #8 FAILED at 723.
Hunk #9 succeeded at 671 (offset -230 lines).
Hunk #10 succeeded at 685 (offset -230 lines).
Hunk #11 FAILED at 697.
Hunk #12 succeeded at 706 (offset -229 lines).
Hunk #13 FAILED at 814.
Hunk #14 succeeded at 780 with fuzz 2 (offset -286 lines).
5 out of 14 hunks FAILED -- saving rejects to file imagefield.module.rej

...but I successfully performed update.php to version 3. How do I get this to work? I don't see how/where the functions would be implemented. I also really need this - thanks in advance!

Fayna’s picture

Fayna commented

Will this be added to new versions of imagefield (like 6.x)? I absolutely love this feature.

bcobin’s picture

bcobin commented

Following up on this - although the update to version 3 seemed to be successful, it actually did hose the module. After a lot of sturm and drang, I ended up going back to the original version - without caption and photo credit capability.

Keeping my eye out for a new version with these capabilities; in the meantime, it's still a great-looking module IMHO.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented
Version: 6.x-3.x-dev » 5.x-2.1
StatusFileSize
new imagefield_caption.patch10.8 KB

I've updated this patch for Imagefield 5.x-2.1, in case anyone's interested.

bcobin’s picture

bcobin commented

Yes - I'm very interested, but I can't get the patch to work. Terminal just hangs. If you have any other ideas (like posting the patched code for the module), that would be great - thanks much!

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented

There is some assistance on using the patch tool in the handbook: http://drupal.org/node/60108
Learning how to use it will help a lot as you learn Drupal.

However, since you asked, I've uploaded the two files you'll need here:

imagefield.install: http://pastebin.com/f3878a6c3
imagefield.module: http://pastebin.com/f74802b68

bcobin’s picture

bcobin commented
Status: Closed (fixed) » Postponed (maintainer needs more info)

Thank you! I've installed the updated versions and see the additional fields on the edit form, where they display in edit mode very nicely. However, the captions don't appear in the Imagefield Gallery view; I would think this would need to be provided for in the Imagefield Gallery module, which is what I'm using.

I'll try posting a link to this post as a support request over there - we could be only a few steps away from having a nice-looking lightbox gallery including captions!

Sorry for taking so long to get back - I was in Denver all last week - thanks again and keep up the great work!

tomchuk’s picture

tomchuk commented

Glad someone is finding this patch useful. The original was against an early Imagefield-2.0 RC which is why the patch wouldn't apply cleanly, sorry for not updating.

I haven't used Imagefield Gallery, but it appears you're going to want to override theme_imagefield_gallery_lightbox2 in your theme to spit out the caption for the thumbnail and/or full views. It may be as simple as changing:

$output .= theme('image', $file['filepath'], $images[$i]['alt'], $images[$i]['title']);

to:

$output .= theme('imagefield_image', $images[$i]);

and tweaking some CSS, but I haven't used lightbox or Imagefield Gallery before, so it may require a little more work.

eclipsegc’s picture

eclipsegc commented

just alter the theme_imagefield_gallery_lightbox2 function in your template.php to include the caption/credits in the alt and title attributes and it SHOULD show up just fine... btw you all are WAY off topic at this point. I'm hoping to have a fix for this in drupal 5 for the next version of imagefield gallery. Imagefield's primary purpose is allow you to upload images to nodes... Credits on that might be nice, but ultimately that's for dopry to decide, and he's busy working on the D6 version of imagefield, so I kind of doubt we'll see this in D5 any time soon unless someone comes up with money to ask him for it... HOWEVER I would imagine this can be done with another module that depends on imagefield.

Eclipse

bcobin’s picture

bcobin commented

Thanks - in my configuration, the function appears in the actual module, not in my template.php, but even so, I tried making the change and... no joy.

I'll probably punt on this right now and see if there's another solution with captions for the next site I do; with all the great work everyone is doing around here, I'm not terribly concerned. Thanks for taking the time with all this - you guys (and girls) are the best!

yang_yi_cn’s picture

yang_yi_cn commented

it's definitely something i will need! thanks for the contribution

tomchuk’s picture

tomchuk commented
Version: 5.x-2.1 » 5.x-2.2
StatusFileSize
new imagefield-5.x-2.2.patch10.46 KB

Updated patch against 5.x-2.2

quicksketch’s picture

quicksketch
he/him
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Thank you for sharing tomchuk, but these patches won't be included directly in ImageField. In Drupal 6 we can use #367267: Compatibility issues with Content Multigroup or create a new widget to store all this extra information.

bryancasler’s picture

bryancasler commented

Will this work with 6.x-3.2 ?

asb’s picture

asb commented
Version: 5.x-2.2 » 6.x-3.x-dev
Status: Closed (won't fix) » Active

Still needing a usable solution for Captions and Copyright/Credits. Content multigroups are miles away from production use (not even in beta stage yet).

I think this is a valid feature request, unless an alternative solution or workaround exists that I'm not aware of.

Greetings -asb

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Closed (won't fix)

Use ImageField Extended.

asb’s picture

asb commented

To save others the time looking this up: Project page is at ImageField Extended - 6.x-4.x branch currently in alpha stage, no co-maintainter, no D7 port, no Views integration yet (?), waiting for inclusion of #735512: Views filefield-data should not be hard-coded.

bryancasler’s picture

bryancasler commented

well crap!, thanks for saving me the headache asb

asb’s picture

asb commented
Issue summary: View changes

I can't believe that there ist still no solution for this issue. So how do we properly implement captions and/or copyright/credits with an imagefield?

The only more or less legally solid approach appears to use image nodes, enter the required data in the node body or customized fields, and then display images with the respective caption/copyright data through Views. Obviously this only covers certain use cases, and it doesn't fulfil the usual legal requirements.