Convert batch_test forms to controllers

I have converted batch_test_chained_form, batch_test_multistep_form,
batch_test_simple_form into Controller. For this I changed batch_test.routing .yml file. used _form parameter instead of _content in router.

I am attaching patch which contains controller of these menu items..

+++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestMultiStepForm.php
@@ -0,0 +1,67 @@
+    // This will only be effective on the last step.
+    $form_state['redirect'] = 'batch-test/redirect';

+++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestSimpleForm.php
@@ -0,0 +1,59 @@
+    $form_state['redirect'] = 'batch-test/redirect';

We could use 'redirect_route' here instead

Thanks for the patch!
Next patch, can you mark the issue as "needs review"?

1. +++ b/core/modules/system/tests/modules/batch_test/batch_test.module
   @@ -70,133 +70,10 @@ function batch_test_menu() {
   -  $form_state['redirect_route']['route_name'] = 'batch_test.redirect';
   ...
   -  $form_state['redirect_route']['route_name'] = 'batch_test.redirect';
   
   +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestMultiStepForm.php
   @@ -0,0 +1,67 @@
   +    $form_state['redirect'] = 'batch-test/redirect';
   
   +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestSimpleForm.php
   @@ -0,0 +1,59 @@
   +    $form_state['redirect'] = 'batch-test/redirect';
   

   These should be redirect_route still

2. +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestChainedForm.php
   @@ -0,0 +1,56 @@
   +  public function submitForm(array &$form, array &$form_state) {
   ...
   +  public function buildForm(array $form, array &$form_state) {
   
   +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestMultiStepForm.php
   @@ -0,0 +1,67 @@
   +  public function submitForm(array &$form, array &$form_state) {
   ...
   +  public function buildForm(array $form, array &$form_state) {
   
   +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestSimpleForm.php
   @@ -0,0 +1,59 @@
   +  public function submitForm(array &$form, array &$form_state) {
   ...
   +    $form['batch'] = array(
   

   Our convention has been to put buildForm before submitForm

3. +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestChainedForm.php
   @@ -0,0 +1,56 @@
   +      #default_value' => 1,
   

   This is missing a '

4. +++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestChainedForm.php
   @@ -0,0 +1,56 @@
   +    $form['#submit'] = array(
   +    'batch_test_chained_form_submit_1',
   +    'batch_test_chained_form_submit_2',
   +    'batch_test_chained_form_submit_3',
   +    'batch_test_chained_form_submit_4',
   +  );
   +
   +  return $form;
   

   These are indented wrong, but also the functions should be converted to methods on this class.

Thanks dawehner, tim.plunkett for reviewing patch..

@tim.plunkett When I tried to add these submit handlers into Class, drupal was not recognizing methods. So could you please help me how to convert these function into methods.

Submitting updated patch..

Sorry, First I had to test it locally, but now I have tested it locally, all test cases are passing. So again I am submitting updated patch..

Submitting new patch. This patch is now locally tested, all test cases are passing..

Updated patch.. Now I have converted

+++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestChainedForm.php

+    $form['#submit'] = array(
+    'batch_test_chained_form_submit_1',
+    'batch_test_chained_form_submit_2',
+    'batch_test_chained_form_submit_3',
+    'batch_test_chained_form_submit_4',
+  );

into

+++ b/core/modules/system/tests/modules/batch_test/lib/Drupal/batch_test/Form/BatchTestChainedForm.php

$form['#submit'] = array(
+      'Drupal\batch_test\Form\BatchTestChainedForm::batchTestChainedFormSubmit1',
+      'Drupal\batch_test\Form\BatchTestChainedForm::batchTestChainedFormSubmit2',
+      'Drupal\batch_test\Form\BatchTestChainedForm::batchTestChainedFormSubmit3',
+      'Drupal\batch_test\Form\BatchTestChainedForm::batchTestChainedFormSubmit4',
+  );

For creating Form object implemented FormInterface instead of

extending

FormBase,
As here we only need very simple form, not required dependencyInjection. it was just creating Form with additional functionality which was not required.

And also converted batch_test_mock_form into Form Object Drupal\batch_test\Form\BatchTestMockForm.
as it was not listed in issue, but I thought this must also converted :-)

Sorry, I was wrong, We have to create form using extending Drupal\Core\Form\FormBase . and also when I converting batch_test_mock_form into Form Object Drupal\batch_test\Form\BatchTestMockForm. Test cases are failing, why it is happening not able to find our reason.. If any one, then please share here..

So please consider my previous patch https://drupal.org/comment/8222485#comment-8222485

We should use FormBase.

Unable to find anything objectionable so RTBC.

EntityCrudHookTest random fail.

Committed 37e61b1 and pushed to 8.x. Thanks!