It looks there's no code (anymore ?) that actually inserts anything in this table

Comments

wmostrey’s picture

wmostrey commented
Status: Active » Fixed

You are correct, this table isn't used anymore. It will be deleted from the next release. Thanks!

yched’s picture

yched commented
Status: Fixed » Active

Cool, thanks ! - there should be an update function for update_bonus to drop the table on existing installs, though ?
Reopening for this :-/

wmostrey’s picture

wmostrey commented
Priority: Normal » Minor

The reason I removed the .install instead of updating it is because I don't like legacy code just sitting there. I'll this as minor and I'll see what I'll to with it. Your point is valid of course.

yched’s picture

yched commented

Heh, nobody does like legacy code, I guess ;-)
But I don't really see update functions as legacy code. Or, a both required and well-contained area where db legacy is taken care of.
Ah, anyway.

wmostrey’s picture

wmostrey commented

Wouldn't this mean that for each new user installing the module it will create the table and then delete it again?

yched’s picture

yched commented

Not if your .install files simply provides an asset_bonus_update_1() function and no asset_bonus_install().

wmostrey’s picture

wmostrey commented
Status: Active » Fixed

Added again for legacy reasons, it's small and simple. Thanks for the tip!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.