"Add a new..." is often redundant in UI strings

Sure. We should fix this for 7.x.

Where is it, though? I grepped for "Add a new" and "add a new" and other than code comments, only turned up "Add a new comment to this page" (which is seems like there was a long issue about) and some help text in profile module regarding profile categories "To add a new category...." . I must be either be missing it or not understand your comment.

I found one reference in profile.module.

Just because, here's a patch that removes the offending "new" reference.

Patch no longer applies.

reroll of #2 against latest HEAD, also strings are already frozen, so this will need to go into 8.x

Reupload of alexanderpas's patch, for test.

Alexaderspas's patch no longer applies. However i found a lot of other corrections myself, here is a patch.

Thanks Elvar for the reroll and the added corrections.

I applied the patch to make sure it didn't need another re-roll. While I was at it, I also did a git grep 'add a new' to find some other changes. Here's a list. Some of them are in comments, which I don't think need to be updated, but it probably wouldn't hurt.

Here's an output of the grep:

core/includes/batch.inc:    // We add a new digit at 200, 2000, etc. (since, for example, 199/200
core/modules/image/image.module:      $output .= '<dd>' . t("Image module also allows you to attach images to content as fields. To add an image field to a <a href='@content-type'>content type</a>, go to the content type's <em>manage fields</em> page, and add a new field of type <em>Image</em>. Attaching images to content this way allows image styles to be applied and maintained, and also allows you more flexibility when theming.", array('@content-type' => url('admin/structure/types'))) . '</dd>';
core/modules/language/lib/Drupal/language/Tests/LanguageListTest.php:    // language so we must add a new language and make it the default before
core/modules/poll/lib/Drupal/poll/Tests/PollCreateTest.php:    // Now add a new option to make sure that when we update the node the
core/modules/system/system.api.php: * updating a site, add a new hook_update_N(), which will be called by
core/modules/user/user.admin.inc: * Form to re-order roles or add a new one.
core/themes/seven/template.php:    $output = '<p>' . t('You have not created any content types yet. Go to the <a href="@create-content">content type creation page</a> to add a new content type.', array('@create-content' => url('admin/structure/types/add'))) . '</p>'

Lets update the patch to add these.

I added dissam #9 mentioned point to this patch..

Thanks,
A. Jaffar ali

Thanks for updating the strings. A couple of suggested changes:

+++ b/core/modules/image/image.module
@@ -115,7 +115,7 @@ function image_menu() {
-    'description' => 'Add a new image style.',
+    'description' => 'Add a image style.',

This should be changed to "Add an image style." And it would be good to wrap it with the t() function.

+++ b/core/modules/image/image.module
@@ -160,7 +160,7 @@ function image_menu() {
-    'description' => 'Add a new effect to a style.',
+    'description' => 'Add a effect to a style.',

This should be changed to "Add an effect to a style." And it would be good to wrap it with the t() function.

Thanks for your suggestion. Here i corrected those changes..

Some minor nitpicks.

This

@@ -685,7 +685,7 @@ function comment_node_view(Node $node, $view_mode) {
           $links['comment-add'] = array(
             'title' => t('Add new comment'),
             'href' => "node/$node->nid",

should say 'title' => t('Add comment'),

See "Add style" and "Add image effect" further down.

This

@@ -36,7 +36,7 @@ function testPollCreate() {
     $this->clickLink($title);
     $this->assertText('Total votes: 0', 'Link to poll correct.');
 
-    // Now add a new option to make sure that when we update the node the
+    // Now add a option to make sure that when we update the node the

should say + // Now add an option to make sure that when we update the node the

This

@@ -863,7 +863,7 @@ function theme_user_permission_description($variables) {
 }
 
 /**
- * Form to re-order roles or add a new one.
+ * Form to re-order roles or add a one.

should say + * Form to re-order roles or add one.

Setting back to needs work.

Thanks for your comment

Also one additional place for comments.

The following is on lines 303-310 of comment.module

  $items['comment/reply/%node'] = array(
    'title' => 'Add new comment',
    'page callback' => 'comment_reply',
    'page arguments' => array(2),
    'access callback' => 'node_access',
    'access arguments' => array('view', 2),
    'file' => 'comment.pages.inc',
  );

Title should read "Add comment"

Also the following in your patch should be changed.

@@ -685,7 +685,7 @@ function comment_node_view(Node $node, $view_mode) {
           $links['comment-add'] = array(
             'title' => t('Add new comment'),
             'href' => "node/$node->nid",
-            'attributes' => array('title' => t('Add a new comment to this page.')),
+            'attributes' => array('title' => t('Add a comment to this page.')),
             'fragment' => 'comment-form',

Title should read "Add comment"

Not sure yet, why previous patch failed, am investigating now.

More occurrences requiring change

\core\modules\comment\lib\Drupal\comment\Tests\CommentLinksTest.php

Lines 246-248

      // User is not allowed to post comments.
      if (!$info['post comments']) {
        $this->assertNoLink('Add new comment');

Should read "Add comment"

Lines 273-279

        // "Add new comment" is always expected, except when there are no
        // comments or if the user cannot see them.
        if ($path == "node/$nid" && $info['form'] == COMMENT_FORM_BELOW && (!$info['comment count'] || !$info['access comments'])) {
          $this->assertNoLink('Add new comment');
        }
        else {
          $this->assertLink('Add new comment');

3 occurrences of "Add new comment" should read "Add comment"

I believe this is were your patch is failing.

Thanks for your comment. Here i corrected all changes as you mentioned.

#19: drupal-add-new-correction-213475-6472728.patch queued for re-testing.

hhmmm unable to apply the patch to new clone of 8.x.

Says an error in core/modules/language/lib/Drupal/language/Tests/LanguageListTest.php:136

Have reviewed the patch and the test file, and I can see no reason.

So will re-test the patch.

OK not sure that was correct. Will upload patch again, and retest.

OK that worked, and have applied patch successfully to new clone of 8.x.

Still finding more places this needs changing.

Here is results of search for 'Add new comment'

And another search for just 'Add new'

Hope these help. Seems this task is growing.

I corrected all changes as you mentioned in 26. Here is the patch

jaffaralia: sorry for the really late review. A quick glance, and this looks good to me, although it needs a reroll. Also, in the future, when you modify an existing patch, please attach an interdiff.txt file as well so we know what you changed.

Rerolled jaffaralias code.

Rerolled jaffaralias code.

Removing "needs reroll" tag.

#32: drupal-profile-add-new-213475-30.patch queued for re-testing.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Since there's been no follow up in 3 months going to close out, but don't worry if still valid it can be reopened. Thanks all!

For what it's worth, the premise of this issue is not always true: Sometimes we are distinguishing "Add new" from "Add existing".

That said, core action links and buttons have undergone a lot of UX review and overhaul since this issue was filed and the general pattern is "+ Add thingy", so outdated is a good status.