Bookmark Ops field in Views has arbitrary value [#213488]

Sadly, I had to disable this module from http://boston2008.drupalcon.org/sessions because of this bug.

This Bookmark: Ops field in Views (see views_bookmark_nodes table definition) shows an arbitrary value because its value is never filtered for the current user. I think the current user should be added to the JOIN with the views_bookmark_nodes table. This should probably happen in the query handler for this field.

I tried to fix this but a bit lost in the query handler. Help moofie!

Comment	File	Size	Author
#3	vb_ops.diff	11.58 KB	mooffie

Comments

Comment #1

moshe weitzman commented 24 January 2008 at 00:45

Actually, we should probably move the 'Bookmark: Ops for @s' field to a new pseudotable that has an 'extra' clause that adds the JOIN on uid = ***CURRENT_USER***. this will cause the least interference with other filters and arguments.

Comment #2

mooffie commented 27 January 2008 at 13:44

Assigned:

Unassigned

» mooffie

I'll work on this today.

Comment #3

mooffie commented 28 January 2008 at 00:22

Status:

Active

» Needs review

Status	File	Size
new	vb_ops.diff	11.58 KB

http://boston2008.drupalcon.org/sessions

Oh, nice! Views_bookmark will be perfect for this! :-)

Ops field [...] shows an arbitrary value because its value is never filtered for the current user.

That's correct.

I'm attaching a patch. (You should apply it to the latest CVS. But, you know, don't do this on a live site --I did test it numerous times, but maybe it won't be the final patch.)

I decided to add a new [pseudo] table. I did a lot of thinking about this, and finally came to the conclusion that it's the better and clearer route.

we should probably move the 'Bookmark: Ops for @s' field to a new pseudotable that has an 'extra' clause that adds the JOIN on uid = ***CURRENT_USER***.

Yes, that's what I did.

this will cause the least interference with other filters and arguments.

That's a by-product, but it actually wasn't my prime rationale.

Notes:

Update path: I didn't want to have to maintain two pieces of code, so I moved the code from 5100 to 5101.
I cleaned up the handlers for the Ops field. So we end up with less code, I think. (But I added some comments.)
I commented-out an unused table, "views_bookmarks_$bookmark->vbid". (You know it's unused because it has a 'table' => 'views_bookmark_nodes_$bookmark->vbid' line --note the *single* quotes.)