Popups to add panes/context/anything else not working (Patch included)

sarvab - January 24, 2008 - 01:13
Project:Panels
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I'm not sure if my version of jQuery is newer than from jquery_update (must be), but it seems that the .top and .left jQuery functions have been removed. This problem would prevent loading the popup in any circumstance, sometimes giving an error JS alert or sometimes not doing anything.

This patch just replaces those two functions. Even if it works for most people it would probably be a good idea for future jQuery updates and if anyone is currently having a problem with popups it may be worth trying.

AttachmentSize
mc.js_.patch2.27 KB

#1

catch - January 25, 2008 - 15:03
Version:5.x-2.0-beta2» 5.x-2.x-dev
Priority:normal» critical

Still there in -dev, sounds critical to me.

#2

lsabug - January 25, 2008 - 16:01

Tried this patch, ran update.php but still getting same error message:

http://dev.domain.org/panels/ajax/add-content/1/row_1_1
missing ; before statement
jquery.js (line 2)

This is a clean intial install of Panels 2 beta2.

#3

merlinofchaos - January 25, 2008 - 17:40

This patch only matters for people who have a newer version of jquery than ships with Drupal.

#4

Pancho - May 28, 2008 - 13:47
Priority:critical» normal

Wouldn't call it critical then, but we should take another look at it before shipping the final.

#5

merlinofchaos - July 9, 2008 - 21:20
Status:patch (code needs review)» fixed

This patch appears to ahve already been applied. Perhaps it was applied as another patch.

#6

Anonymous (not verified) - July 31, 2008 - 04:46
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.