I'm not sure if my version of jQuery is newer than from jquery_update (must be), but it seems that the .top and .left jQuery functions have been removed. This problem would prevent loading the popup in any circumstance, sometimes giving an error JS alert or sometimes not doing anything.

This patch just replaces those two functions. Even if it works for most people it would probably be a good idea for future jQuery updates and if anyone is currently having a problem with popups it may be worth trying.

CommentFileSizeAuthor
mc.js_.patch2.27 KBsarvab

Comments

catch’s picture

catch
he/him
Primary language English
commented
Version: 5.x-2.0-beta2 » 5.x-2.x-dev
Priority: Normal » Critical

Still there in -dev, sounds critical to me.

lias’s picture

lias commented

Tried this patch, ran update.php but still getting same error message:

http://dev.domain.org/panels/ajax/add-content/1/row_1_1
missing ; before statement
jquery.js (line 2)

This is a clean intial install of Panels 2 beta2.

merlinofchaos’s picture

merlinofchaos commented

This patch only matters for people who have a newer version of jquery than ships with Drupal.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Priority: Critical » Normal

Wouldn't call it critical then, but we should take another look at it before shipping the final.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

This patch appears to ahve already been applied. Perhaps it was applied as another patch.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.