Themes: avoid clashes with system colors
Mental - January 24, 2008 - 12:28
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | Garland theme |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
I'm not sure, whether this is garland-specific.
Anyway, when you set the "color" of an input field, please also set it's "background-color" (and vice versa). Otherwise the background color of the input (and select) fields is set by the web browser to a color which is usually OS theme-specific. Using an OS theme where the input controls are painted dark or black, black text in them remains invisible. I'm even writing this bug report into drupal.org practically blindfoldedly.
| Attachment | Size |
|---|---|
| Sample screenshot | 54.24 KB |
#1
Changed version: 5.6 -> 6.0. Issue still occurs.
#2
Here's a trivial patch to fix this in the Garland theme and probably avoid some W3C CSS validation warnings about this issue. Anybody alive?
#3
Still occurs in Drupal 6.2.
#4
It took me a while to realize what the problem was, but it's definitely a legitimate issue. When you set the foreground color of an element the background color should be specified at the same time, you can't guarantee that the background will always stay the same color across all devices and systems.
I haven't tested this patch but it looks good. Mental, can you make sure all the other core themes get the same treatment?
#5
Ok, this will do for the Chameleon and Garland (and Minnelli?) themes on the screen. However, Garland also has a print.css for print media, and I can't promise that it will work properly for printing. Analyzing and rewriting the whole theme - I don't have the time. Where are your theme developers?
Some more remarks - Garland was the only theme always using custom input field colors. Chameleon only coloured the erronous input fields, which still produced this issue, so I changed it to handle all the input fields. The other themes don't specify custom colours for the input fields and therefore these just look ugly when using some dark-coloured system colour schemes, but they are still readable.
#6
I noticed that the Chameleon theme didn't have a background or foreground color on the body element, which is a big problem (the whole page changes color). I've created a new patch for this.
I also found a nice dark Ubuntu theme that I've decided to keep, however as Mental already pointed out, the d.org theme becomes much harder to use (I'm using a custom Human theme).