The edit webform results is a great feature addition and one which I just told the client couldn't be done. However, Edit own webform results does not work unless you have rights to view webform results which shows you all results. It seems that what is actually missing is the additional user permission to view own webform results. This is key for our application because we want extranet users to be able to view and edit their submissions but we wouldn't want them to be able to view other people's submissions.

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

Thanks, you're quite right. I can see scenarios where admins would want to let users only view their own submissions and not edit them either. I've added another permission for 'access own webform submissions' that is checked as an alternative to 'access webform results'. You can try out the latest dev version that contains these changes until 1.9 is released (which mostly will fix new problems introduced in 1.8).

Bodo Maass’s picture

Bodo Maass commented

This doesn't seem to work yet. Using 5.x-1.x-dev from January 26 2008, I cannot get the results tab to appear for authenticated users unless I give them 'access webform results' permission. With 'access own webform submissions' or 'edit own webform submissions' or both, the results tab will not appear.

quicksketch’s picture

quicksketch
he/him
commented

The results tab will not be shown for users that do not have 'access webform results' permission, because it contains information about other users' submissions. The only way (currently) to view results for users that have 'access own webform submissions' is to go to node/x?sid=y. To edit the submission end-users may go to node/x?sid=y&op=edit.

Bodo Maass’s picture

Bodo Maass commented

Thanks, the link node/x?sid=y seems to work for end users.
Now I have a role that has 'access webform results' permission. When I look at the webform in this role, I see a results tab. This tab lists all results with links of the form node/x/results/view/y. When I click on one of these links, I get 'Access Denied'.
The links of the first form do work, though. This seems to be a bug.

Bodo Maass’s picture

Bodo Maass commented

One more observation: If I give the role from #4 the additional permission 'edit webform submissions' I can view (and edit) the results through the results tab. However, 'access webform results' on its own does not seem to work correctly.

sander-martijn’s picture

sander-martijn commented
Status: Fixed » Active

Thanks for working on this - the site i have been working on just went live and it looks like you're still working on fixing this (so not sure about the fixed status). I think that the correct solution to this is to have it look the same - i.e. have a results tab, but that tab only displays the user's own results if that user only has view/edit own webforms results. Otherwise how will they get to them?

I'll keep an eye on this issue though and if it sounds like it's fixed properly then I'll test it out for this site.

thanks for your efforts

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

The suggestions by sander-martijn has now been implemented in the 2.x version of the module. Unfortunately due to the differences between 1 and 2 versions of the module it's not trivial to backport. As new features are only being added to the 2.x version, I'm marking as fixed. You'll need to upgrade to the latest 2.x version.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.