The items that location adds to node edition forms are ugly, and carries an table, which is not recommended by drupal UI guideline, and make the themers work quite hard.

CommentFileSizeAuthor
#2 location.htmloutput.module.patch2.45 KBwundo

Comments

wundo’s picture

wundo commented
Title: Ugly and not themeable html being generate » Ugly and not themeable html being generated
Assigned: Unassigned » wundo

I'm working on a patch for that.

wundo’s picture

wundo commented
Status: Active » Needs review
StatusFileSize
new location.htmloutput.module.patch2.45 KB

This patch removes the theme_location_form dependence and do a cosmetic change in the form layout when displaying only one location.

bdragon’s picture

bdragon commented
Status: Needs review » Needs work

Not so sure about the patch.

Can we just revisit this after I finish the "convert to elements" changes I'm working on? It will be much easier to do at that time.

smitty’s picture

smitty commented

If you should decide to take out this table I would suggest to do something for a nice theming of the location form input. There is a patch of ray007, which supports a nicely themed output without using any table. Please have a look at: http://drupal.org/node/132445.

bdragon’s picture

bdragon commented

I'm DEFINATELY taking the damn table out.

bdragon’s picture

bdragon commented
Status: Needs work » Fixed

The table has since gone away.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.