notice: Undefined index: parent in modules/taxonomy/taxonomy.admin.inc on line 760.

Seems straightforward, will patch shortly.

(Getting deja vu, though - didn't we fix a ton of notices in taxonomy already? How did we miss this one?)

CommentFileSizeAuthor
#1 taxonomy_admin_inc_notice-214154-1.patch1 KBcburschka

Comments

cburschka’s picture

cburschka
they
commented
Status: Active » Needs review
StatusFileSize
new taxonomy_admin_inc_notice-214154-1.patch1 KB

It's a very long line, and I have applied the trivial (isset) fix rather than hunt around for possible details - eg. when the ['parent'] gets set, if this bug happens only when no parent is selected, when no possible parent exists, or when the forum module unsets the parent field.

This patch removes the notice, although if forum.module causes this, perhaps forum.module should be fixed to keep its change free of notices...

cburschka’s picture

cburschka
they
commented
Status: Needs review » Closed (duplicate)

If my version of the abovementioned patch gets in, this one becomes superfluous. I really prefer the idea of fixing the bug at the source, because it shouldn't be the responsibility of every module to be paranoid about its own form values just in case some other module "hacked" it with form_alter.