Some changes Patch
sinasalek - January 26, 2008 - 07:07
| Project: | Longer Node Titles |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | sinasalek |
| Status: | won't fix |
Jump to:
Description
Hi,
I wrote a module with the same concept. and after i found this module i prefer to merge it instead of adding new one.
I attached the patch , hope you accept it.
| Attachment | Size |
|---|---|
| longer_title_1-1.patch | 2.03 KB |
#1
hi, but is there any principal difference in functionality?
#2
No, just a different approach.
I will modify columns instead of renaming them and
i added this two lines :
// Override the publication node reference in all forms
$form['field_reference_publication'][0]['node_name']['#maxlength'] = 255;
// Override the event node reference in all forms
$form['field_event_reference'][0]['node_name']['#maxlength'] = 255;
But it seems that your module works without them.
#3
sinasalek, if there is no much difference, then let's leave the module as it is now. because i have not got used to easily manage my cvs account yet. every time it is a headache to me.
#4
No problem,
PS : I have the same problem with CVS! wish drupal upgrade to SVN ;).
#5
@sinasalek: when you override a field that may or may not be present, you really need to do an "isset" on it first. Otherwise you could end up inserting junk into the form.
"$form['field_reference_publication'][0]" and "$form['field_event_reference'][0]" look like CCK references. What about sites that don't have CCK or aren't using those particular fields? Yes, there are sites without CCK - more than half of mine lack it.
BTW, when you attach a patch to an issue, you should set the status to "patch (code needs review)".
#6