notice: Undefined variable: form_values in /var/www/www.astrocalc.com/htdocs/sites/all/modules/switchtheme/switchtheme.module on line 151.

a review with coder module shows:

switchtheme.module

    *
      severity: critical Line 151: use $form_state['values'] instead, which is where the values are stored after a submit

          variable_set('theme_default', $form_values['custom_theme']);
CommentFileSizeAuthor
#3 switchtheme.patch758 bytessun

Comments

vikingew’s picture

vikingew commented

and the fix:

changing variable_set('theme_default', $form_values['custom_theme']);

to

variable_set('theme_default', $form_state['values']['custom_theme']);
fixes it ;-)

vikingew’s picture

vikingew commented
Status: Active » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Undefined variable: form_values » Do not switch a site's default theme
StatusFileSize
new switchtheme.patch758 bytes

IMHO, SwitchTheme should never ever allow users to switch the default theme of a site. This happens exactly in this line.

Instead of fixing this bug, I'd propose to remove the line completely.
The same change is already incorporated in the the patch in #185254: Themes don't switch for anonymous users.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)

Marking as duplicate of #247348: Switchtheme switches the default theme not the users'