Hi Ted,
I really think we should merge Elf anf URL Class [1], as the only differences I found after a quick review are:

  • Elf prodivdes default icons for external and mailto links
  • URL Class provides different css classes based on the linked domain

Additionally we could think about integrating the functionality that URL Icon [2] provides, which fetches the favicons from the remote site and adds them to the external link.

What do you think?

[1] http://drupal.org/project/urlclass
[2] http://drupal.org/project/urlicon

Comments

m3avrck’s picture

m3avrck commented

Yes I agree, merging some modules would be great.

I searched for a while to find other modules that work with external links and didn't come across yours -- must have been not so common name :)

I propose the following...

- new option to "add unique class for each domain" that when enabled, adds an additional class for each domain so you end up with class="external-link google". Then, if that option is enabled, it will include the CSS file using that icon instead of the other one. This would basically replace URL class so it can be used in external links -- which makes sense, agree?

- option to fetch favicons on a cron run. If enabled, on hook_cron, this module would go through all new content that has been added since previous cron (using a simple variable_get('last-nid', 0) and for each one *use* CURL to fetch the favicon and store it in drupal/files/favicons/site-name.ico -- this option would then work with the above option (so it basically enables both) to add in the icon next to each link.

This would be a bit complicated to add so sending this stuff in patches as chunks would be a best option. The first option would be a good starter patch.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Subscribing.

As If’s picture

As If commented

I think this is a great idea, can I suggest one more thing to add? A boolean setting for ' target="_blank"' could be added to elf_replace().

csc4’s picture

csc4 commented

Subscribing - this would be a great addition

realityloop’s picture

realityloop commented

Subscribing - this would be a great addition

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Project: External Links Filter » URL Icon
Version: 5.x-1.0 » 6.x-2.0
Assigned: Unassigned » sanduhrs
Status: Active » Fixed

I merged the URL Class [1] and the URL Icon [2] modules and added settings for each input format.
Now URL Icon [2] supports to
* automatically add the corresponding favicon, if the site has one
* add an external link icon (included)
* add a CSS class only, so that you can theme it as you like

That was the quick fix.

[1] http://drupal.org/project/urlclass
[2] http://drupal.org/project/urlicon

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.