The current draggable icon uses a matte white background that looks very poor if the user has a dark background. It is not noticeable in the default garland, because the background is white.
I cannot make a .patch for it, because the .png format is binary, and diff doesn't do binary files. This just goes in the misc folder, over the current draggable.png.
The icon was originally a GPL X11 cursor theme (called flatbed), but I modified it so heavily that if it wasn't it would probably be ok.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | drag_icon_II.patch | 444 bytes | zeta ζ |
| #3 | draggable.png | 278 bytes | zeta ζ |
| #3 | drag_icon.patch | 350 bytes | zeta ζ |
| #2 | draggable-improved-quad.png.gz | 307 bytes | neomenlo |
| draggable-improved.png.gz | 362 bytes | neomenlo |
Comments
Comment #1
yched commentedThe current icon is quadri-directional (up-down-left-right). This is important because drupal's drag-n-drop lets you move items on the horizontal axis as well for tree structures nesting.
Also, please don't set your own patches to 'ready to be committed'. They're 'needs review' or 'needs work' until another reviewer declares them RTBC.
Comment #2
neomenlo commentedI'm very sorry about setting the wrong status. I also did not realize that there was a a quad directional functionality to the feature.
I have modified the one used in drupal originally to have a white border all the way around the cursor, instead of at the center, like the old one. This makes it look much nicer in darker themes. It still works fine in IE6.
Comment #3
zeta ζ commentedLooks much neater (though difficult to tell at only 100%). Arrows are more distinct and symetrical, though there is still one pixel a bit different just above the right arm of the black arrow (even more difficult to tell at 100% ;-).
I’m not sure why these need to be 15×40: would 13×26 still work? or is this to keep the script generic?
The movement between the two images on hover, is in system.css. As the height is also set in the previous rule, there is no reason why they can’t be co-ordinated.
I’ve included my version of the icon, and a patch for the .css
Comment #4
zeta ζ commentedOK, forget I said anything: 13×26 doesn’t work in .
My first paragraph still stands though (the previous post!).
Comment #5
dpearcefl commentedIs this still a need? Perhaps it should be moved to D7 or D8?