The image button value handler originally used the variable name $array for some of its internal work. We changed it to use $post later, but one instance snuck through. When multiple image buttons are present in a form using #TREE = TRUE, notices are thrown because of the bogus variable. This patch just fixes the error, changing the variable name.

Thanks, E_ALL!

CommentFileSizeAuthor
image_button_fix.patch643 byteseaton

Comments

eaton’s picture

Priority: Normal » Critical

Took a closer look, and realized this will prevent proper submission of forms using image buttons if #tree is used. Bumping it up to critical.

pasqualle’s picture

Status: Needs review » Reviewed & tested by the community

Tested with form in css injector module.
The E_notice is gone after the patch.

the bug is evident, the fix is good.

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.