The "All Comments" feed doesn't provide any information about the node that's being commented on, which virtually forces the user to visit the node to figure out what the comment means. This patch provides the node title in each comment for the "All Comments" feed, which should help at least a little.

CommentFileSizeAuthor
#4 include_node_title.patch2.88 KBgábor hojtsy
#3 contrib-5.commentrss.comment-context3.junyor.patch1.96 KBjunyor
#1 contrib-5.commentrss.comment-context2.junyor.patch1.93 KBjunyor
contrib-5.commentrss.comment-context.junyor.patch1.91 KBjunyor

Comments

junyor’s picture

junyor commented
StatusFileSize
new contrib-5.commentrss.comment-context2.junyor.patch1.93 KB

Better patch that solves the same problems for taxonomy feeds, too.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

- I would not call a string $node, since it is quite misleading.
- It would be great to use t() on the string, so that translators can translate it.

Otherwise looks good. Thanks for working on this.

junyor’s picture

junyor commented
StatusFileSize
new contrib-5.commentrss.comment-context3.junyor.patch1.96 KB

Updated patch to incorporate your feedback and fix the link so it actually works.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 5.x-1.x-dev » 5.x-2.x-dev
Assigned: Unassigned » gábor hojtsy
Status: Needs work » Fixed
StatusFileSize
new include_node_title.patch2.88 KB

I'd say we need this in all feed types, except the node feed type. So I thought it would be useful to have an optional argument $include_node_title = TRUE on the function and then pass on FALSE for the single node feed. So I implemented and committed this to 5.x-2.x-dev.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.