available tokens in page_title 2 alpha 4?

That's exactly right. I wonder if this is a bug introduced by the "node as page and not teaser" check.

Same here. Any updates yet?

I haven't had a chance to investigate this as yet - but I'm wondering if its related to this issue 211640...

I get the same thing when I try to use [term] or any other token in the default pattern. I'm not using cck.

Nick, isn't this related to that issue we fixed with the hack before xmas in alpha 2?

I refer to the token substitution failing; we added a line of code to refresh all the tokens I think, somewhere around line 326.

This would be why you were thinking it's similar to http://drupal.org/node/211640 - it's the same place, but different code. Maybe the solution in 211640 is ok after all?

Either way, P_T doesn't work right now (with CCK/Token).

Nik

Edit: this was the working code; it still appears to function, albeit that you referred to it as a hack, previously. I'll test it against views and whatever, see if anything goes pop...

326      // Return the title
327      token_get_values('global', NULL, TRUE);
328      $title = token_replace($page_title_pattern);

Can this patch please be reviewed (against the Page Title 2.x-dev branch) please?

If this is 'okayed' Then we will have a Page Title 2.0-alpha5.

Changes made in this patch:
1) Changed the 'page_title_page_get_title' function so that, instead of just getting the type for the node, it grabs the entire node. Then the token replace line is replaced with a check if the node is set. If not, it uses the global scope for tokens otherwise it uses the node scope and passes the node over. This SHOULD solve the lack of node-level tokens. I have tested this and can confirm tokens such as [author-name] and [term-name] are now working. My dev install doesn't have CCK or Views though, however I am about to test against those.

2) Non critical change, I added a 'preview' op to the nodeapi implementation. This causes the page title to appear on node-edit forms not just node-view.

3) Removed the page_title_get_type function as this was no longer needed due to the changes outlined in change (1).

Please let me know how this goes...

My code fix in #5 hasn't blown anything up yet. Edit: your code fix, that I rescued from an old backup.

1) What the hell are you talking about?
2) "node just", LOLLERS.
3) see 1)

Cheers,
Nik

1) What the hell are you talking about?

This issue is all about Page Title not being aware of the node being viewed in terms of available tokens. This is because we only ever call token_replace in global mode, we never pass it the node. This patch solves this by passing the node if it is available and reverting to 'global' if the node is not available.
The solution of flushing the token cache and rebuilding it for our own needs is hackish and inefficient. Its far better to use whatever data has been statically cached in the module whenever we can than just flushing it because we're not using the token_replace function properly. In any case, your fix (as far as I can see) wont/shouldn't solve this problem as its still not passing the node over to token_replace.

2) "node just", LOLLERS.

Thanks for elegantly pointing out my typo. Its fixed now - sorry if it offended you ;-)

3) see 1)

I dont think I can make that sentence any more idiot proof... There was a function that, due to changes described previously, was not being used anymore. I therefore removed it.

Hi Nick,

I tested this patch on 2 sites, one with CCK and one without. It worked fine for me on both.

Thanks

Thanks for testing icelink.

I shall commit this patch and release an Alpha5.

globalredirect_node_patch.patch...? :) Well, I applied it to page_title and it seemed ok... ;)

However... on my install, I get the "better" page title only on node/*/edit, which doesn't seem like the desired outcome...

Pretty odd really. No change at all on /node/x

No change on node/x?!

What you running (server versions, core version, modules (+version), etc)?

What did you patch against? alpha4 or dev?

globalredirect_node_patch.patch...? :)

Ahh I get what you mean now NikLP... That was my mistake! I think I was doing some patch work for PT and GR and must have got muddled up in my head.

I'm marking this as fixed as I've just tested all that I can think of to reproduce the issue NikLP has had and I cant make it. I'm guessing that something went wrong with the patch (maybe a different version was patched?)...

I've just branched Page Title 2.0 - Alpha 5. Please test this and let me know what you think.

I've installed a fresh version of this, but I still have the same issue :( - I can only see the optimised title in the node/*/edit screen.

I haven't a clue what this is about, or how to debug it. Thoughts/ideas?

Subscribing, very interested in this. Greetings, Martijn

I've had success using [title] - [term-raw] But it only returns the first term.

Issue created here...
http://drupal.org/node/224597