Currently we name our fields/filters/sorts in this manner:
Bookmark: bookmarks Marked Time
Bookmark: User for bookmarks
Bookmark: Count for bookmarks
Bookmark: Ops for bookmarks
Bookmark: todo Marked Time
Bookmark: User for todo
Bookmark: Count for todo
Bookmark: Ops for todo
I propose to name them thus:
Bookmark: bookmarks: Marked Time
Bookmark: bookmarks: User
Bookmark: bookmarks: Count
Bookmark: bookmarks: Ops
Bookmark: todo: Marked Time
Bookmark: todo: User
Bookmark: todo: Count
Bookmark: todo: Ops
What's your opinion on this?
Comments
Comment #1
mooffie commentedThe downside, assuming most admins have only one 'mark', is that 'Bookmark: bookmarks: xyz' will look strange to them; they won't understand why the repetition.
Comment #2
quicksketch+1 on consistency. I also like the format. I've tried making all of them 'bookmarks Marked Time' and 'Marked Time for bookmarks', both looked out of place for some applications. Your format, though a bit redundant, I think fits in with other options provided by views modules and is clear.
Comment #3
alanburke commentedCoupled with the proposed name change
http://drupal.org/node/202249
this makes even more sense
How about a using two different seperators instead of 2 double colons:
Bookmark: bookmarks -> Marked Time
Bookmark: bookmarks -> User
Comment #4
mooffie commentedI don't think users will understand what "->" means :-) It isn't used anywhere else.
BTW, in Views2 this dropdown will use OPTGROUP so we will get rid of the first 'Bookmark:' prefix.
Comment #5
mooffie commentedThere's one stumbling block in this issue:
The meaning of "Bookmark: xyz: User" won't be immediately clear for admins.
It stands for the user who bookmarked the node(s). (yeah, I know, it's a general-use module so the word 'bookmarked' isnt' accurate.)
Right now the dropdown says "Bookmark: User for xyz". This wording isn't perfect either, but it's much clearer than what we plan here.
What motivates me to change the current wording, which isn't bad, is one and only one thing: to introduce this "xyz: " prefix, which will provide clear visual distinction between these field groups. This will lower the risk of admins unintentionally and erroneously mixing fields form different marks.
Or am I imagining all this? Is "Bookmark: xyz: User" clear enough? We will also have a "Bookmark: xyz: UID" argument.
Any ideas? opinions?
Comment #6
mooffie commentedYou know,
This might be another good reason to change the name of this module. If we name it after some object, the field names might be self-documenting.
(Let's not elaborate here. I'm afraid of "project-name squatters" lurking around ;-)
Comment #7
mooffie commentedMaybe, instead of a "xyz:" prefix we should have a "for xyz:" one?
Bookmark: for bookmarks: Marked Time
Bookmark: for bookmarks: User
Bookmark: for bookmarks: Count
Bookmark: for bookmarks: Ops
Bookmark: for todo: Marked Time
Bookmark: for todo: User
Bookmark: for todo: Count
Bookmark: for todo: Ops
Comment #8
doc2@drupalfr.org commentedI've read the whole topic.
+1 for #7! This is much clearer indeed!
Comment #9
alanburke commentedHmmm
I guess I still think two different seperators are needed
Maybe -> isn't suitable
But something is needed to show the the two pieces of text to the right belong together
How about -
Bookmark: bookmarks - Marked Time
Bookmark: bookmarks - User
I don't like the repeated use of the word 'for'
The full colon, or whatever second seperator is used, should do the job of explaining that thoses two peiece of text belong together.
If you prefer to use the word 'for', How about
Bookmark: Marked time for bookmarks
Bookmark: User for bookmarks
In fact, on consideration, I might even prefer this myself!
Regards
Alan
Comment #10
alanburke commentedUnbelievable :-(
I suggest going back to the way we currently are.
I'll have a think about this further, and see if I can think of anything better
Regards
Alan
Comment #11
mooffie commentedNathan, here's the patch I propose. I use 'of' instead of 'for', so the dropdowns should look like:
Bookmark: of bookmarks: Marked Time
Bookmark: of bookmarks: User
Bookmark: of bookmarks: Count
Bookmark: of bookmarks: Ops
Bookmark: of todo: Marked Time
Bookmark: of todo: User
Bookmark: of todo: Count
Bookmark: of todo: Ops
I'm promoting this to 'critical'. The current lables have a major usability bug:
(...or should we use commas instead of colons?
Bookmark: of bookmarks, Marked Time
Bookmark: of bookmarks, User
Bookmark: of bookmarks, Count
Bookmark: of bookmarks, Ops
Bookmark: of todo, Marked Time
Bookmark: of todo, User
Bookmark: of todo, Count
Bookmark: of todo, Ops)
Comment #12
doc2@drupalfr.org commentedI don't really like "of", nor the comma either.
While the comma seems to gather the first words around it in a "kind of sentence", I find it too litteral though. And with "of" moreover, it sounds like an unfinished sentence. Meanwhile with the semi-column it's clear that we have a list.
That might be too much of language considerations though. Please don't leave my point of view alone on the subject!
PS: Anyways, if the module name changes, it might lower the cases of "Bookmark: of/for bookmark..." kind of display style. We may barter for another "New-name: of/for new-name"... which won't be better... so that the question's still opened.
Comment #13
quicksketchJust a thought... if we renamed the module custom_flags, our prefix would be "Flag", eliminating the confusion of the
Bookmark: bookmarks: Marked Timeoptions. It'd be a little silly to name a flag "Flag" (it could be done of course), so we'll avoid that problem out-of-the-box and if the user decides to name a flag "Flag", they'll probably already understand how to use the module.Marked Time would probably also be changed to Flagged Time if we go with the change.
Comment #14
alanburke commentedWell the module is now Flag... so this is pretty much sorted
Comment #15
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.