Creating this to promote awareness of the apparent underlying issue in Entityreference: #2151631: Improve performance of getReferencableEntities(). Marking as postponed based on that issue.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ezra-g’s picture

Priority: Major » Critical
Status: Postponed » Active
Issue tags: +commons 7.x-3.6 radar

Following discussion in #2151631, it turns out that the user_trusted_contacts field is actually an options select list, thus the need to query on all referencable entities. This isn't apparent without looking at the field definition because this is meant to be used programmatically and we hide it in the UI.

So, the change here is to make the widget type for user_trusted_contacts an autocomplete widget, even though users should never see the field :). Adding to the Commons 3.6 radar and marking as "critical" since it's pretty disruptive to be unable to edit user accounts.

japerry’s picture

Assigned: Unassigned » japerry
japerry’s picture

Here is a patch for to revert the options list into an autocomplete

japerry’s picture

Status: Active » Needs review
japerry’s picture

Status: Needs review » Fixed

I've tested against new installs and upgrade paths, all seem to work. I've committed this in prep for tomorrows release, but if we have other performance issues, feel free to re-open.

http://drupalcode.org/project/commons.git/commit/f5f25c3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.