Download & Extend

Prevent meltdown in cache_get()

Project:Drupal core
Version:5.x-dev
Component:base system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

If a site is busy at the time the garbage collector kicks in, it is possible for the system to have a meltdown if nothing finishes the garbage collect fast enough.

AttachmentSizeStatusTest resultOperations
cache_meltdown.patch1023 bytesIgnored: Check issue status.NoneNone

Comments

#1

Same for HEAD.

AttachmentSizeStatusTest resultOperations
cache_meltdown_HEAD.patch1 KBIgnored: Check issue status.NoneNone

#2

Status:needs review» reviewed & tested by the community

1 line change, good to go, already live on drupal.org.

#3

Version:5.x-dev» 6.x-dev

This should go into D6 first.

#4

Version:6.x-dev» 5.x-dev

Great, committed to 6.x. RTBC for 5.x.

#5

Are you really sure this makes sense?

If a cache is not flushed successfully - the variable shouldn't tell it is flushed successfully. This change sounds very illogical and keeps stale data.

#6

Hass, the variable_set() never checked the success of the query, so there is no such change as you explained.

#7

Status:reviewed & tested by the community» fixed

Committed to 5.x.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#9

Priority:critical» normal
Status:closed (fixed)» active

Hi guys,

I think the "well rounded" / "good" behavior would be adding a global variable to determine "being flushed", and not use the "flushed" variable as it is confusing and erratic as hass correctly mentioned.

This is from a good practices point of view,

To your review,
Etamar

#10

etamar, doesn't work the fix for you?

#11

Status:active» closed (fixed)

No answer, so a positive is assumed. Closed again.

nobody click here