It looks like the comment for user_login_submit() function was meant for user_authenticate_finalize(). However, that function already has a nice comment. So here's one for user_login_submit().

CommentFileSizeAuthor
#3 userloginsubmit_2.patch838 bytesgábor hojtsy
userloginsubmitjv.patch827 bytesjvandyk

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

+1 Very nice.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new userloginsubmit_2.patch838 bytes

Well, while we are on the cleanup, to obey to coding standards, we should use a one line summary and then a longer explanation. Modified the comment format to do that. Committed this one.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.