Sitewide Contact Form Missing Required Email Address
| Project: | Drupal |
| Version: | 5.6 |
| Component: | contact.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
We have a sitewide contact form (http://greenopolis.com/beta/contact), which requires a user to enter his or her name, email address, etc. When the form is submitted and the email message is generated, the user's email address is not included in the message that gets constructed in the contact_mail_page_submit($form_id, $form_values) function.
There is a record in watchdog.
I'd like to see something like this:
sent a message using the contact form at !form.", array('!name' => $form_values['name'], '!form' => url($_GET['q'], NULL, NULL, TRUE), '!email' => $form_values['mail']));
$message[] = $form_values['message'];
?>
Is this just an oversight, or is there a reason why the email address is not currently being passed in the body of the message?
| Attachment | Size |
|---|---|
| contact.01292008.patch | 1.17 KB |
#1
The reason why this is happening on my site is because I am using the SMTP module, which is overwriting the From field.
However, I contend that at the very least, the contact_mail_page_submit() function should set the Reply-to header to $form_values['mail'].
#2
Ok, but why hacking the core? Can you do something like making your own custom module and adding the _validate or _submit hooks at _form_alter for the 'contact-mail-page' form?
#3
The contact modules does put the correct value for the from/reply-to field. The only problem is with the SMTP module overwriting the value.
#4
Thank you for the patch. Sad to have to patch a core module, but I am sure this is a reason for not having the email in the body. I just can't think of a good reason, but hey, this is not the first Drupal quirk I see, so...