If you don't fill in all the fields of an address, when they are displayed in node and teaser view, you get blank lines where the empty fields.
Is there way to concantate this so there isn't this large are of white space?

CommentFileSizeAuthor
#3 address_space.png9.75 KBrconstantine
#2 address-whitespce.jpg24.16 KBagilpwc

Comments

rconstantine’s picture

rconstantine commented
Category: bug » support
Status: Active » Fixed

The README has a theming section that you should have read. That's how you deal with such things. Theme function overrides are simple to do and are a basic Drupal skill that you should learn. This is not a bug.

agilpwc’s picture

agilpwc commented
Status: Fixed » Closed (works as designed)
StatusFileSize
new address-whitespce.jpg24.16 KB

I agree I should learn more about themeing, and calling it a 'bug' probably wasn't the right term.

Please don't get defensive, but I still think there is an "error" of some sort. If you look at the attached screenshot. There is more whitespace than address.

What is the purpose of line 1230 in the theme function?
$output .= '<br /><br />';

Seems like unnessary white space.

rconstantine’s picture

rconstantine commented
StatusFileSize
new address_space.png9.75 KB

Don't worry, I wasn't getting defensive. It's just that the README tells users ahead of time that they may need to override (not modify) those functions to suit their needs. The amount of white space you have is more than three times the amount I have with the same theme function and CSS. I'm attaching a typical screen shot from one of my sites. Although this is an Event content type, the spacing is the same for all content types which use this module on all of my sites.

So I'm guessing that your site's CSS overrides the browser's default handling of the <br /> tag. It may be that nearly everything else you have uses other tags like <p> or <div> for vertical line spacing and so you just never noticed before. Try using Firebug in Firefox to find out. And again, it looks like you'll have to override the theme function or the CSS.

rconstantine’s picture

rconstantine commented

By the way, in the screen shot I attached, most of the white space is due to the <p> for the paragraph following the address.