Excuse me if this is not a 'bug' but I thought the info would be useful.

I'm using Tortoise CVS to extract logintoboggan from cvs.drupal.org contributions. For some reason it doesn't download the .js file, UNLESS I select the HEAD version.

Any reason why that might be so?

I've worked around it by downloading from the project page and inserting it into my cvs depository.

CommentFileSizeAuthor
#5 install.txt2.1 KBjbc

Comments

jbc’s picture

jbc commented

I see now that the .js file is missing for all 5.x-1.1 version (incl. dev). Is reason for this explained anywhere? Will it be returning? I really like this module, but do miss this js functionality.

hunmonk’s picture

hunmonk commented
Status: Active » Closed (works as designed)

there is no .js file in the 5.x release -- the javascript is embedded in the module code itself, and should be working perfectly.

the .js file was created in 6.x to increase jquery compatibility -- the change was not backported.

jbc’s picture

jbc commented

ok, that makes sense. however, I can no longer find anywhere to switch on the js capability....ahhh! I've just realised it's in the block configuration. Can I make this a feature request: that this choice

Block type: O Standard O Link O Collapsible form

be moved from login block settings into logintoboggan settings??!!

(I remember now, it's not the first time I've lost this. And I'm not a Drupal newbie...)

Just a thought. Sorry if you feel i've wasted your time. For my 2cents it would be an improvement.

Cheers

hunmonk’s picture

hunmonk commented

i won't move the location of that setting. it's in a block, it belongs on the block config page. if you'd like to submit a patch that more clearly documents it's location (perhaps in INSTALL.txt), then i would be happy to review it.

feel free to reopen the issue in that case.

jbc’s picture

jbc commented
StatusFileSize
new install.txt2.1 KB

Suggested --- Install.txt

If you care to check that I've documented it correctly, please do. I believe it's accurate.

INSTALLATION:

Place entire loggintoboggan module folder into
(a) your sites/all/modules directory
(b) your sites/[my site]/modules directory.
(avoid the temptation to place it directly into the /modules directory -- when upgrading your site it is important to identify all 'contributed' [i.e. non-core] modules seperately, since they must be upgraded too)

Enable loggintoboggan module at
Administer -> Site building - > Modules

Configure loggintoboggan settings at
Administer -> User management -> LoginToboggan.

The module changes the functionality of the login block
AND provides a new 'LoginToboggan logged in block'

Configure each block at
Administer -> Site building -> Blocks
as follows...

1. Configure the 'User login' block for LoginToboggan functionality:

Change title if required; using <none> can make for a very neat login system, when combined with the javascript functionality: clicking upon "login / register" reveals the login form in neat sliding fashion. To select this functionality: select 'Collapsible form' under "Block type: O Standard O Link O Collapsible form." Link sends user to a login form, returning them to original page after successful login.

Other block configuration options are standard.

DON'T FORGET TO "SAVE" BLOCK CONFIGURATION before browsing to another page

2. Configure 'LoginToboggan logged in block'

Tip: by leaving the title blank, the 'LoginToboggan logged in block' is slim and neat. So slim and neat that it can be inserted into the 'header' block region. Try it! It appears in the top right hand corner of your site.

Otherwise standard block confguration options.
DON'T FORGET TO "SAVE" BLOCK CONFIGURATION before browsing to another page

Done!

hunmonk’s picture

hunmonk commented
Status: Closed (works as designed) » Needs work

you need to submit this as a patch, in unified diff format in order for me to properly review it:

http://drupal.org/patch/create

jbc’s picture

jbc commented

I won't be submitting it as a patch. Since current module has no install.txt, you have suffficient information to review it.

hunmonk’s picture

hunmonk commented

there are already install instructions listed in README.txt. a proper patch needs to be submitted to either

  1. add the additional install instructions to README.txt
  2. remove the current README.txt section on installation, and merge it with an INSTALL.txt
jbc’s picture

jbc commented

Fine. I understand the p.o.v. that a patch is required.
Perhaps you can do that or a.n. other concerned Drupal-zen.

The install.txt is offered AS IS; I think it's an improvement others may be interested in.
But I don't have the skills for patching. Nor presently the time to learn them.

Cheers.

hunmonk’s picture

hunmonk commented
Title: cvs download » add INSTALL.txt, clarify login block setting location
Version: 5.x-1.1 » 5.x-1.x-dev

But I don't have the skills for patching. Nor presently the time to learn them.

i highly encourage you to carve out some time for it -- it's really not that hard to learn, and it saves module authors a lot of headache. it's certainly going to slow down this current issue...

jbc’s picture

jbc commented

Thanks for the encouragement. Fact is, I'm presently carving out all the time I can spare developing my existing Drupal skills and drills and patching, for me, is not near the top of the list.

FWIW: Some appreciation for the contribution of the text I've provided would also have provided a more convincing context for your encouragment.

You're no worse off for the contribution I've made, though you almost sound like you feel you are.

Take it or leave it; but don't let it give you a headache!

hunmonk’s picture

hunmonk commented

point taken. and i do appreciate that you've taken the time to try and move the module forward.

a lot of this has to do with developing a set of guidelines that helps keep me sane as a module maintainer. i do this all for free as well, and i also don't have tons of spare time. i've decided that i don't want to spend much of it doing work to convert submitted work to the proper reviewable format.

after you've had people submit the entire module file (with their few changes to it) and ask for it to be reviewed, you start setting some guidelines as to the work you'll accept ;)

and for the most part, i think this guideline results in a healthier overall community -- if i were to simply accept work that came in without regard to the format, people would be less likely to take the time to learn the skill of submitting it in the proper format. nobody wins in that case.

jbc’s picture

jbc commented

I think that's quite a reasonable stance. Particularly with regard towards code. If and when I get to the point that I'm submitting code, I'll certainly bear in mind your points and make sure I know how to patch.

And thanks again for a great module...as well as all the other work you do for the Drupal project and community.

shalom!

hunmonk’s picture

hunmonk commented
Status: Needs work » Fixed

finally got around to integrating this into the module. thanks for the start!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.