Logo image overlaps with center DIV.

ao2 - January 31, 2008 - 16:30
Project:Drupal
Version:7.x-dev
Component:Garland theme
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

When we set a void left panel, the bottom of the logo image overlaps with the top of the center DIV.

Steps to reproduce:

  • Log in as Administrator
  • Go to Administer -> Site building -> Blocks
  • Move any items away from the Left sidebar region
  • Save and logout

I would have expected no ovelaps. Have a look in the upper left part of the attached picture to see the current, wrong, behaviour.

Please, even if this is a really trivial bug, and people are going to replace the image logo, it would be nice to have that fixed before 6.0

Thanks,
Antonio

AttachmentSizeStatusTest resultOperations
drupal-garland-logo-overlap-when-no-leftpanel.png94.17 KBIgnoredNoneNone

#1

dvessel - February 1, 2008 - 22:23
Version:6.0-rc3» 6.x-dev
Status:active» needs review

This will pretty much fix it but there is a very, very subtle color mismatch due to the gradient. If we wanted to get rid of that too, the base.png and logo.png graphics would have to be tweaked.

This is also present in Minnelli.

AttachmentSizeStatusTest resultOperations
garland-minnelli-logo-shift.patch536 bytesIgnoredNoneNone
logo-upshift.png13.38 KBIgnoredNoneNone

#2

catch - February 1, 2008 - 22:29

#3

zeta ζ - February 1, 2008 - 23:44

Yes, it looks good to me, don’t notice the mismatch. But with a left sidebar I think the logo is noticeably too high.

This makes the same change but conditional on left sidebar presence. I’ve put a class on #header, in case anything else wants to depend on it.

AttachmentSizeStatusTest resultOperations
no_left_sidebar.patch1.01 KBIgnoredNoneNone

#4

dvessel - February 2, 2008 - 00:19

1.) <body> already puts out the layout classes.
2.) Is it the height really that noticeable?

IMO, It's not needed.

#5

zeta ζ - February 2, 2008 - 01:10
  1. Didn’t think of that as I wanted no left sidebar
  2. Yes, I think it is, as it is next to the site name, and it would be nice to leave it in place for everyone else

This is not such a big change. Tested both themes, with and without right and left sidebars.

AttachmentSizeStatusTest resultOperations
no_left_sidebar_II.patch577 bytesIgnoredNoneNone

#6

ao2 - May 13, 2009 - 14:53

this bug is still here in 6.11.

If it is not going to be fixed, can you devs at least mark it "won't fix"?

Thanks,
Antonio

#7

ao2 - May 28, 2009 - 17:56
Version:6.x-dev» 7.x-dev

Even in drupal7

#8

catch - June 1, 2009 - 23:27
Status:needs review» needs work

does the CSS really need to be this specific?

+body.sidebar-left #wrapper #container #header h1 img, body.sidebars #wrapper #container #header h1 img {
+  padding-top: 16px;
+}

 
 

Drupal is a registered trademark of Dries Buytaert.