Download & Extend
Issues

Different $node->path for authenticated vs anonymous users

Posted by Rob Loach on January 31, 2008 at 6:17pm
Project:Drupal core
Version:5.x-dev
Component:path.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It seems like when an annonymous user is visiting a Drupal site, dumping $node, returns an empty $node->path. When logged in, however, $node->path is effectively setup. The SQL runs fine, can't find out what's wrong with $node->path.

Any ideas?

Login or register to post comments

Comments

#1

Posted by budda on January 31, 2008 at 6:19pm

The problem is that the path_nodeapi() call that inserts the path attribute ($op = 'load') will never get called for anon users UNLESS they have been granted either 'create url aliases' || 'administer url aliases' permissions!

#2

Posted by Damien Tournoud on February 1, 2008 at 8:23am
Version:5.x-dev» 6.x-dev

It feels like we could load the path attribute no matter what permissions the user have. This "bug" is also present in 6.x, so reassigning.

#3

Posted by Rob Loach on February 1, 2008 at 3:44pm
Component:node system» path.module
Status:active» needs review

This patch removes the check for the 'create url aliases' || 'administer url aliases' permissions.

AttachmentSizeStatusTest resultOperations
drupal_6_path_nodeapi_1.patch2.89 KBIgnored: Check issue status.NoneNone

#4

Posted by Damien Tournoud on February 1, 2008 at 7:30pm

The user_access() check is still needed for every operation that is not "load". Please only remove it for that operation.

Damien

#5

Posted by webchick on February 1, 2008 at 9:18pm
Status:needs review» needs work

#6

Posted by Rob Loach on February 1, 2008 at 11:32pm
Status:needs work» needs review

This patch uses user_access on everything except 'load'.

AttachmentSizeStatusTest resultOperations
drupal_6_path_nodeapi_2.patch2.51 KBIgnored: Check issue status.NoneNone

#7

Posted by Rob Loach on February 1, 2008 at 11:37pm

A bit more elegant.

AttachmentSizeStatusTest resultOperations
drupal_6_path_nodeapi_3.patch787 bytesIgnored: Check issue status.NoneNone

#8

Posted by Christefano on February 2, 2008 at 2:54am

This is my favorite issue of the month. And February just started!

#9

Posted by moshe weitzman on February 2, 2008 at 3:51am
Status:needs review» reviewed & tested by the community

#10

Posted by Christefano on February 2, 2008 at 5:30am

Whoops, I meant to mark it RTBC. Thanks, Moshe.

#11

Posted by Damien Tournoud on February 2, 2008 at 2:56pm

+1, seems good to go.

#12

Posted by Gábor Hojtsy on February 3, 2008 at 7:20pm
Status:reviewed & tested by the community» fixed

Ugh, committed.

#13

Posted by Damien Tournoud on February 3, 2008 at 11:52pm
Version:6.x-dev» 5.x-dev
Status:fixed» patch (to be ported)

We need a backport for 5.x.

#14

Posted by Rob Loach on February 4, 2008 at 8:46am
Status:patch (to be ported)» needs review

Moved to the DRUPAL-5 branch.

AttachmentSizeStatusTest resultOperations
drupal_5_path_nodeapi_1.patch730 bytesIgnored: Check issue status.NoneNone

#15

Posted by Damien Tournoud on February 4, 2008 at 10:56am
Status:needs review» reviewed & tested by the community

Not much to say: applies cleanly, does what advertised :)

#16

Posted by cburschka on February 6, 2008 at 11:14am

Thank you ever so much for this! I've grown extremely tired of manually loading the alias from the database when I needed it in a node object.

#17

Posted by mzafer on February 10, 2008 at 5:40am

Subscribing

#18

Posted by drumm on February 11, 2008 at 5:12am
Status:reviewed & tested by the community» fixed

Committed to 5.x.

#19

Posted by Anonymous (not verified) on February 25, 2008 at 5:12am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#20

Posted by tommo on June 13, 2008 at 3:59pm
Title:Different $node->path for authenticated vs anonymous users» Isn't fixed in 5.x
Status:closed (fixed)» active

Hi, this is a bug I was interested in back in January, I put a site live having to use drupal_get_path_alias('node/'.nid) to set the path for anon users. I'm just developing a new site and noticed that this issue should be fixed.

I'm using Drupal 5.7 and pathauto 5.x-2.2 and am doing a node_load()

The path is there for me as administrator but not there for anonymous users. I haven't set any permissions for anonymous users but reading through this issue I'm assuming I shouldn't have to.

#21

Posted by Rob Loach on June 13, 2008 at 4:08pm
Status:active» fixed

Correction, this isn't fixed in Drupal 5.7. It will, however, be fixed in Drupal 5.8.... If you look at http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/path/path.module?r... , you'll see that the DRUPAL-5 branch has the fix, while the DRUPAL-5-7 tag (http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/path/path.module?r...) doesn't.

#22

Posted by webchick on June 13, 2008 at 4:11pm
Title:Isn't fixed in 5.x» Different $node->path for authenticated vs anonymous users

Resetting title.

#23

Posted by Anonymous (not verified) on June 27, 2008 at 4:12pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.