If you validate the installation page, it is invalid because the link:

Line 39, Column 89: cannot generate system identifier for general entity "locale".

…a href="/install.php?profile=default&locale=en">try again</a>.</p>

CommentFileSizeAuthor
#8 amp.patch1.22 KBgábor hojtsy
#6 install_php_strict2.patch3.03 KBvladimir.dolgopolov
#3 install_php_strict.patch3.48 KBvladimir.dolgopolov

Comments

dsoneira’s picture

dsoneira commented

&amp;locale instead of &locale should fix it.

Bence’s picture

Bence commented

Yes, obviously, but I am not involved in developing Drupal (yet?).

There is an another error on the "Learn how to install Drupal in another language" page: There is no attribute "target" in XHTML 1.0 Strict.

vladimir.dolgopolov’s picture

vladimir.dolgopolov commented
Status: Active » Needs review
StatusFileSize
new install_php_strict.patch3.48 KB

Here is the patch, that fixes that.

It replaces some & with & a m p; and I decided to remove target="_blank" from install.php so it goes against "XHTML 1.0 Strict":

  1. HTML and XHTML Frequently Answered Questions
  2. Serving "Valid" XHTML Strict with target="_blank"

Maybe it's good to use JavaScript here, but IMHO it is not worth the trouble.

Bence’s picture

Bence commented

I don't think that JS is good solution for this. Better solutions:

1. Remove the target attribute, and use XHTML 1.0 Strict
2. Keep the target attribute, and use on those pages XHTML 1.0 Transitional

The 1. solution is the most straightforward.

cburschka’s picture

cburschka
they
commented

Users can decide just fine on their own whether or not they want to open a new page, which is really why the target attribute is getting deprecated. The first solution makes the most sense.

vladimir.dolgopolov’s picture

vladimir.dolgopolov commented
StatusFileSize
new install_php_strict2.patch3.03 KB

Some fix for the prev patch (form action handle).

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Trivial patch, applies cleanly, rtbc.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.0-rc3 » 7.x-dev
StatusFileSize
new amp.patch1.22 KB

Well, I went ahead and committed the & fix, as attached. I'd argue that the target attribute is an important measure there to not drive the user out of the install process right away on a link which would be most often clicked, so I did not commit that one. I believe the user experience is more important here, and I sincerely cannot think of a situation, where the user would not select to open this in another window (it is complicated enough to get back to this page after a download and uncompress process with the translation, especially for newbies).

The attached patch can get this fix in line with 7.x.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.