Comments

mgifford’s picture

mgifford’s picture

Status: Active » Needs review
StatusFileSize
new197 bytes

There is still a formatting issue, but the boxes are there.

mgifford’s picture

mgifford’s picture

Project: Drupal.org site moderators » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Other » Code

Maybe this should be moved to customizations.. This is an easy fix.

drumm’s picture

Project: Drupal.org customizations » Bluecheese
Version: 7.x-3.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

When editing patches, keep the header with the filename. There isn't any context for what file #3 patches.

The grid classes were removed intentionally, see #1580272: Replace grid-x classes with semantic classes. Instead of hard-coding widths, use Susy mixins. This will help move the theme and content toward being responsive.

All custom CSS should be added to the theme instead of the module.

mgifford’s picture

StatusFileSize
new547 bytes

I need someone else to come up with the Susy mixins..

I must have just taken a shortcut to create the previous diff. Sorry.

Thanks again for the direction.

EDIT: I think this is a good source for info about setting up mixins, but didn't find a good example of setting up columns in Bluecheese I could emulate https://gist.github.com/ericam/1163463

mparker17’s picture

Status: Needs work » Needs review
StatusFileSize
new725 bytes

Turns out that all the color-swatch class needed was an explicit height. Rewrote the patch from scratch (so no interdiff). Will deploy to staging shortly.

Edit: deployed to https://search_api-drupal.redesign.devdrupal.org/node/1051644

mparker17’s picture

StatusFileSize
new337 bytes
new1.04 KB

After talking with @drumm in IRC, I'm putting the class in the "_about.scss" partial instead of a new one.

Edit: Changes deployed to https://search_api-drupal.redesign.devdrupal.org/node/1051644

drumm’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.