Closed (fixed)
Project:
Bluecheese
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jan 2014 at 22:37 UTC
Updated:
20 Mar 2014 at 00:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mgiffordThis is true - https://web.archive.org/web/20120609135315/http://drupal.org/node/1051644
The CSS must have been missed:
https://drupal.org/node/1051644
Comment #2
mgiffordThere is still a formatting issue, but the boxes are there.
Comment #3
mgiffordWith formatting - http://search_api-drupal.redesign.devdrupal.org/node/1051644
Comment #4
mgiffordMaybe this should be moved to customizations.. This is an easy fix.
Comment #5
drummWhen editing patches, keep the header with the filename. There isn't any context for what file #3 patches.
The grid classes were removed intentionally, see #1580272: Replace grid-x classes with semantic classes. Instead of hard-coding widths, use Susy mixins. This will help move the theme and content toward being responsive.
All custom CSS should be added to the theme instead of the module.
Comment #6
mgiffordI need someone else to come up with the Susy mixins..
I must have just taken a shortcut to create the previous diff. Sorry.
Thanks again for the direction.
EDIT: I think this is a good source for info about setting up mixins, but didn't find a good example of setting up columns in Bluecheese I could emulate https://gist.github.com/ericam/1163463
Comment #7
mparker17Turns out that all the
color-swatchclass needed was an explicit height. Rewrote the patch from scratch (so no interdiff). Will deploy to staging shortly.Edit: deployed to https://search_api-drupal.redesign.devdrupal.org/node/1051644
Comment #8
mparker17After talking with @drumm in IRC, I'm putting the class in the "_about.scss" partial instead of a new one.
Edit: Changes deployed to https://search_api-drupal.redesign.devdrupal.org/node/1051644
Comment #9
drummCommitted http://drupalcode.org/project/bluecheese.git/commit/f5a2344 and deploying shortly.