For the e-Commerce module there is a wrong security update warning, and even worse, there is no way to ignore it.
Last stable version, as far as I can tell is 3.4, there is a security update for 4.0 alpha (but that is alpha).
First, this should not be reported as a security update.
Second, it should be possible to ignore it. But the only option is 3.4 in the ignore list (and that won't make any difference of course).
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | update_ignore_higher_branches.d5.patch | 1.64 KB | dww |
| #2 | update_ignore_higher_branches.d6.patch | 1.57 KB | dww |
| e-CommerceUpdateStatus.png | 22.88 KB | mariuss |
Comments
Comment #1
dwwArgh, yes. Confirmed. :( Debugging now.
Comment #2
dwwDrat. :( The problem is that there's code to ignore releases from higher branches, other then finding the "Also available" release. However, there's really two things going on inside this code block: 1) find "Also available" if we don't have it, 2) ignore the release. Unfortunately, #1 requires that the higher branch is considered a supported release, whereas we *always* want to do #2. :( So, the if clause just needs to be split up into 2 pieces, so that we always test the major version, then, inside that if block, we see if the higher version is supported and if we need to populate "Also available". but then, even if it's not supported, we ignore the release by hitting the "continue". Tested on D5 and fixes the originally reported bug. This should go into core ASAP (I hope before the 6.0 final release). If the original reporter of this bug could test the D5 version of the patch attached here and confirm it solves the problem, that'd be great.
Thanks,
-Derek
Comment #3
webernet commentedTested the 5.x patch, and it successfully fixes the problem for ecommerce.
The 6.x code is the same, applies cleanly, and doesn't seem to break anything, so this should be ready to go.
Comment #4
coltraneTested D5 patch and it fixes the issue.
Drupal 5.7 with ecommerce installed. Installed update_status module and received security warning. Applied patch and warning went away. Installed old pathauto module (pathauto-5.x-1.2) and received security warning recommending upgrade to pathauto-5.x-2.0.
Comment #5
dwwNote: this patch also fixes the bug reported at http://drupal.org/node/216309
Given the further testing and reviews in here (and more testing myself), I committed the D5 version to update_status contrib DRUPAL-5--2: http://drupal.org/cvs?commit=98869
6.0 really shouldn't go out with this code, so I'm changing the title appropriately.
Sorry about this bug -- it was introduced fixing other bugs, and I never tested the case where newer releases went out that aren't supported. :(
Comment #6
gábor hojtsyHm, discussed this with dww on Skype as well. Looks good, committed. Thanks for testing!
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.