Internet Explorer + popup = bug (and fix)
g10 - February 1, 2008 - 18:52
| Project: | Splash |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi,
very handy module but there is a small problem with Internet Explorer and a popup…
the setup:
splash page that is allways shown, that page has a javascript popup, the popup shows the drupal front_page
in every browser this works, except in Internet Explorer, there the popup shows again the splash page instead of the required front_page
any ideas where the problem comes from??
(by having a quick look in the module, I suppose I should do something with the cookie the module sets before calling the popup script)
#1
this issue offcourse only manifest itself in very unique cases, and only IE suffers from it
nonetheless, included is a patch that solves this issue...
basicly before calling window.open() in the javascript to create a popup, there should be set another cookie so the module knows a popup is coming who does not require a redirect to the splash page
2 lines should be added to the page.tpl / page-content_type.tpl that will make a popup window:
in the header :
<?phpprint splash_js();
?>
in the (inline) javascript function before calling window.open() :
<?phpprint splash_popup_cookie();
?>
#2
I find this .patch quite 'hacky' while a better and more simple solution exists which at the same time also adds a funny feature for site administrators to bypass the splash when they want to. Check out the patch (will be added in next release).
The new 'feature' it brings: bypass the splash by going to example.com?nosplash instead of example.com.
The way it solves your problem: just add
?nosplashto the URL you're opening in the popup.#3
Automatically closed -- issue fixed for two weeks with no activity.