Add ability to secure Nodes based on Content Type

I just did a quick test of this patch and it seems to work. It is EXACTLY what I needed. Thank you so much for posting this patch, and I sincerely hope that it is formally evaluated and folded into the active code soon. It makes the module much more useful.

I would rather have a select list but I agree with vikinzer and think this is ready for the next release.

No I do not believe that is something to add to secure pages.

There is an api which allows you to set the secure flag on the menu item and then secure pages will make the switch a lot faster and use less resources to do this.

example:

function foo_menu($may_cache) {
  if (!$may_cache && arg(0) == 'node' && is_numeric(arg(1)) && !arg(2)) {
    $node = node_load(arg(1));
    if ($node->nid && $node->type == 'story') {
      $items[] = array('path' => 'node/'. arg(1), 'title' => t('View'),
        'callback' => 'node_page_view',
        'callback arguments' => array($node),
        'access' => node_access('view', $node),
        'type' => MENU_CALLBACK,
        'secure' => 1,
      );
  }
  return $items;
}

This will secure all store node types.

Gordon.

In that case, I'll be watching #227633 with renewed interest.

This sounds very interesting, how does it work?

I've tried adding the snippet to a new module and can't seem to make it work, any more info would be greatly appreciated

This does not work in Drupal 6. There's nothing in the code that even checks for such a flag as far as I can tell and I can't even get a hook_menu function like this but ported to 6 to execute at all with the right values because of Drupal's menu cache. I think this does belong as a feature native to securepages - users shouldn't be expected to write a custom module to do this.

Recently had cause to implement this functionality for the securepages module in Drupal 6.

I've implemented a slightly different flavor of this feature while working on #587000: Cached pages are not being redirected - you can find the patch at http://drupal.org/node/587000#comment-5304070.

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks